Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover specs with PHPStan #10059

Merged
merged 6 commits into from
Jan 2, 2019
Merged

Cover specs with PHPStan #10059

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1376307
Update PhpSpec to ^5.0
pamil Dec 31, 2018
7913eeb
Setup spec paths in autoload-dev in the main package
pamil Dec 31, 2018
6b9357d
Fix spec classnames / filenames mismatches
pamil Dec 31, 2018
8994f2c
Make PHPStan for specs passing
pamil Dec 31, 2018
6cee10b
Make PhpSpec passing after fixing PHPStan warnings
pamil Dec 31, 2018
a007c90
Remove PHPStan extension for Symfony
pamil Dec 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make PhpSpec passing after fixing PHPStan warnings
  • Loading branch information
@pamil
pamil committed Dec 31, 2018
commit 6cee10bc420b46db1a23b96cde05562ac8a0a30f
2 changes: 1 addition & 1 deletion src/Sylius/Bundle/OrderBundle/spec/Controller/AddToCartCommandSpec.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ final class AddToCartCommandSpec extends ObjectBehavior
{
function let(OrderInterface $order, OrderItemInterface $orderItem): void
{
$this->beConstructedThrough('createWithCartAndCartItem', [$order, $orderItem]);
$this->beConstructedWith($order, $orderItem);
}

function it_is_add_cart_item_command(): void
Expand Down