Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover specs with PHPStan #10059

Merged
merged 6 commits into from
Jan 2, 2019
Merged

Cover specs with PHPStan #10059

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1376307
Update PhpSpec to ^5.0
pamil Dec 31, 2018
7913eeb
Setup spec paths in autoload-dev in the main package
pamil Dec 31, 2018
6b9357d
Fix spec classnames / filenames mismatches
pamil Dec 31, 2018
8994f2c
Make PHPStan for specs passing
pamil Dec 31, 2018
6cee10b
Make PhpSpec passing after fixing PHPStan warnings
pamil Dec 31, 2018
a007c90
Remove PHPStan extension for Symfony
pamil Dec 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update PhpSpec to ^5.0
  • Loading branch information
@pamil
pamil committed Dec 31, 2018
commit 1376307bcf196860fbeb5dad555b22d48c591f41
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"zendframework/zend-stdlib": "^3.1"
},
"require-dev": {
"akeneo/phpspec-skip-example-extension": "^3.0",
"akeneo/phpspec-skip-example-extension": "^4.0",
"behat/behat": "^3.2",
"behat/mink": "^1.7@dev",
"behat/mink-browserkit-driver": "^1.3",
Expand All @@ -90,7 +90,7 @@
"matthiasnoback/symfony-dependency-injection-test": "^2.0",
"mikey179/vfsStream": "^1.6",
"pamil/prophecy-common": "^0.1",
"phpspec/phpspec": "^4.0",
"phpspec/phpspec": "^5.0",
"phpstan/phpstan-doctrine": "^0.10",
"phpstan/phpstan-shim": "^0.10",
"phpstan/phpstan-symfony": "^0.10",
Expand Down
3 changes: 1 addition & 2 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,13 @@ parameters:
reportUnmatchedIgnoredErrors: false

symfony:
container_xml_path: var/cache/dev/appDevDebugProjectContainer.xml
container_xml_path: var/cache/dev/appAppKernelDevDebugContainer.xml

excludes_analyse:
# Makes PHPStan crash
- '**/DependencyInjection/Configuration.php'

# Test dependencies
- '**/spec/**.php'
- '**/Bundle/*/test/app/**.php'
- '**/Bundle/*/test/src/**.php'

Expand Down