Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with availability checker service ids #17606

Closed
loevgaard opened this issue Jan 6, 2025 · 1 comment
Closed

Problems with availability checker service ids #17606

loevgaard opened this issue Jan 6, 2025 · 1 comment
Labels
Bug Confirmed bugs or bugfixes. DX Issues and PRs aimed at improving Developer eXperience.

Comments

@loevgaard
Copy link
Contributor

Sylius version affected: 1.14

In Sylius 1.14 a new service id for the available checker was introduced, namely sylius.checker.inventory.availability. This is also the id being used most places (not here \Sylius\Bundle\InventoryBundle\DependencyInjection\Configuration::getConfigTreeBuilder though).

However, in \Sylius\Bundle\InventoryBundle\DependencyInjection\SyliusInventoryExtension the alias sylius.availability_checker is created and if you have decorated that id in your application, your decoration isn't applied anymore the way you'd expect.

@GSadee GSadee added DX Issues and PRs aimed at improving Developer eXperience. Bug Confirmed bugs or bugfixes. labels Jan 9, 2025
@GSadee
Copy link
Member

GSadee commented Jan 9, 2025

Hi @loevgaard! Thanks for raising the issue, I have just opened the PR with a potential solution, will you take a look?

mpysiak added a commit that referenced this issue Jan 10, 2025
| Q               | A
|-----------------|-----
| Branch?         | 1.14
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | fixes #17606, after
#17306
| License         | MIT

Indeed, the id used on other services was changed from
`sylius.availability_checker` to the new
`sylius.checker.inventory.availability` and it did not point to the
alias previously used, so this can create problems in end applications,
the proposed solution should solve this problem.

<!--
 - Bug fixes must be submitted against the 1.13 branch
 - Features and deprecations must be submitted against the 1.14 branch
- Features, removing deprecations and BC breaks must be submitted
against the 2.0 branch
 - Make sure that the correct base branch is set

To be sure you are not breaking any Backward Compatibilities, check the
documentation:

https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
@GSadee GSadee closed this as completed Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes. DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Development

No branches or pull requests

2 participants