Skip to content

Commit

Permalink
[Maintenance] Add info about private services to UPGRADE.md (#17312)
Browse files Browse the repository at this point in the history 
| Q               | A
|-----------------|-----
| Branch?         | 2.0
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no/
| Deprecations?   | no
| Related tickets | #17276
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.13 branch
 - Features and deprecations must be submitted against the 1.14 branch
- Features, removing deprecations and BC breaks must be submitted
against the 2.0 branch
 - Make sure that the correct base branch is set

To be sure you are not breaking any Backward Compatibilities, check the
documentation:

https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
  • Loading branch information
@GSadee
GSadee authored Oct 23, 2024
2 parents f538917 + d0d996f commit 3660f94
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 53 deletions.
8 changes: 8 additions & 0 deletions UPGRADE-2.0.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@

* The `swiftmailer/swiftmailer` dependency has been removed. Use `symfony/mailer` instead.

## Service Container

In Sylius 2.0, we have changed the visibility of services to `private` by default. This change enhances the performance and maintainability of the application and also follows Symfony's best practices for service encapsulation.

**Exceptions:**
- Services required by Symfony to be `public` (e.g., controllers, event listeners) remain public.
- Services used in `ResourceController` must be `public` as they are accessed directly from the container.

## Codebase

* Doctrine MongoDB and PHPCR is no longer supported in ResourceBundle and GridBundle:
Expand Down
53 changes: 0 additions & 53 deletions adr/2022_02_11_declaring_services_in_container.md
View file

This file was deleted.

0 comments on commit 3660f94

Please sign in to comment.