fix count for github

StefKors · Nov 1, 2024 · c5759ef · c5759ef
1 parent 68c4731
commit c5759ef
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/Shared/UserInterface/Icons/DiscussionCountIcon.swift b/Shared/UserInterface/Icons/DiscussionCountIcon.swift
@@ -9,8 +9,19 @@ import SwiftUI
 
 struct DiscussionCountIcon: View {
     var count: Int?
+    var provider: GitProvider
+
+    private var min: Int {
+        switch provider {
+        case .GitHub:
+            0
+        case .GitLab:
+            1
+        }
+    }
+
     var body: some View {
-        if let count = count, count > 1 {
+        if let count = count, count > min {
             if count <= 50 {
                 HStack(spacing: 2) {
                     Text(Image(systemName: "bubble.left.and.bubble.right"))
@@ -32,6 +43,6 @@ struct DiscussionCountIcon: View {
 
 struct CommentIcon_Previews: PreviewProvider {
     static var previews: some View {
-        DiscussionCountIcon(count: 12)
+        DiscussionCountIcon(count: 12, provider: .GitHub)
     }
 }
diff --git a/Shared/UserInterface/Views/DoubleLineMergeRequestSubRowView.swift b/Shared/UserInterface/Views/DoubleLineMergeRequestSubRowView.swift
@@ -23,7 +23,7 @@ struct DoubleLineMergeRequestSubRowView: View {
 
             HStack(alignment: .center, spacing: 4) {
                 if let count = request.discussionCount, count > 1 {
-                    DiscussionCountIcon(count: count)
+                    DiscussionCountIcon(count: count, provider: request.provider)
                 }
                 MergeStatusView(request: request)
 

diff --git a/Shared/UserInterface/Views/HorizontalMergeRequestSubRowView.swift b/Shared/UserInterface/Views/HorizontalMergeRequestSubRowView.swift
@@ -19,7 +19,7 @@ struct HorizontalMergeRequestSubRowView: View {
 
             Spacer()
             if let count = request.discussionCount, count > 1 {
-                DiscussionCountIcon(count: count)
+                DiscussionCountIcon(count: count, provider: request.provider)
             }
             MergeStatusView(request: request)
             // TODO: support github pipelines