Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): prevent hide when focus is within tooltip #1811

Merged
merged 9 commits into from
Oct 30, 2024
Merged

fix(tooltip): prevent hide when focus is within tooltip #1811

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6b11d3c
fix(tooltip): prevent hide when focus is within tooltip
dancormier Sep 4, 2024
2a6c2f5
Add tests
dancormier Oct 29, 2024
161061e
Merge branch 'develop' into dcormier/fix-tooltip-focus-within-hide
dancormier Oct 29, 2024
345f8d8
formatting
dancormier Oct 29, 2024
fdb7870
prefer usage of waitFor and waitForElementToBeRemoved over sleep func…
giamir Oct 30, 2024
fb0c543
formatting
giamir Oct 30, 2024
1e4907b
simplify the hiding logic when focus is in the popover element
giamir Oct 30, 2024
86bcb59
remove unnecessary binding
giamir Oct 30, 2024
54bc2f4
Remove aria-hidden from tooltip docs
dancormier Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove aria-hidden from tooltip docs
  • Loading branch information
@dancormier
dancormier committed Oct 30, 2024
commit 54bc2f47e87963160190e630c5b5f682291809b8
6 changes: 2 additions & 4 deletions docs/product/components/popovers.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,8 +591,7 @@ <h1 class="s-page-title--header" role="presentation">Lorem ipsum</h1>
<div
class="s-popover s-popover__tooltip"
id="tooltip-example"
role="tooltip"
aria-hidden="true">
role="tooltip">
<div class="s-popover--arrow"></div>
<div class="s-popover--content">
…
Expand All @@ -611,8 +610,7 @@ <h1 class="s-page-title--header" role="presentation">Lorem ipsum</h1>
<div
class="s-popover s-popover__tooltip"
id="tooltip-example"
role="tooltip"
aria-hidden="true">
role="tooltip">
<div class="s-popover--arrow"></div>
<div class="s-popover--content">
<div class="s-empty-state wmx2">
Expand Down
Loading