build(deps): upgrade eslint to v9 (#1856)

StackExchange · Nov 26, 2024 · 63f7062 · 63f7062
1 parent 7a26544
commit 63f7062
Show file tree

Hide file tree

Showing 13 changed files with 342 additions and 365 deletions.
diff --git a/.eslintignore b/.eslintignore
diff --git a/.eslintrc.js b/.eslintrc.js
diff --git a/.vscode/extensions.json b/.vscode/extensions.json
@@ -1,7 +1,5 @@
 {
     "recommendations": [
-        "dbaeumer.vscode-eslint",
-        "esbenp.prettier-vscode",
         "stylelint.vscode-stylelint"
     ]
-}
+}
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -0,0 +1,28 @@
+import prettier from "eslint-config-prettier";
+import js from "@eslint/js";
+import ts from "typescript-eslint";
+import nounsanitized from "eslint-plugin-no-unsanitized";
+
+export default ts.config(
+    js.configs.recommended,
+    nounsanitized.configs.recommended,
+    ...ts.configs.recommended,
+    prettier,
+    {
+        rules: {
+            "no-console": "error",
+            "no-alert": "error",
+            "no-process-env": "error",
+            "@typescript-eslint/no-unused-vars": [
+                "error",
+                {
+                    destructuredArrayIgnorePattern: "^_",
+                },
+            ],
+            "@typescript-eslint/no-unused-expressions": "off",
+        },
+    },
+    {
+        ignores: ["node_modules", "dist", "**/*.js"],
+    }
+);
diff --git a/lib/components/expandable/expandable.ts b/lib/components/expandable/expandable.ts
@@ -28,7 +28,7 @@ function globalChangeListener(e: UIEvent) {
             let customEvent;
             try {
                 customEvent = new Event(RADIO_OFF_EVENT);
-            } catch (ex) {
+            } catch {
                 // Internet Explorer
                 customEvent = document.createEvent("Event");
                 customEvent.initEvent(RADIO_OFF_EVENT, true, true);

diff --git a/lib/components/select/select.a11y.test.ts b/lib/components/select/select.a11y.test.ts
@@ -61,7 +61,6 @@ describe("select", () => {
                 default: child(state.attr),
             },
             template: ({ component, testid }) =>
-                // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
                 template({ component, testid, className: state.class }),
             options: {
                 includeNullModifier: false,

diff --git a/lib/components/select/select.visual.test.ts b/lib/components/select/select.visual.test.ts
@@ -62,7 +62,6 @@ describe("select", () => {
                 selected: child(state.attr),
             },
             template: ({ component, testid }) =>
-                // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
                 template({ component, testid, className: state.class }),
             options: {
                 includeNullModifier: false,

diff --git a/lib/components/uploader/uploader.ts b/lib/components/uploader/uploader.ts
@@ -137,7 +137,7 @@ export class UploaderController extends Stacks.StacksController {
 
         if (file.type.match("image/*") && file.data) {
             thumbElement = document.createElement("img");
-            // eslint-disable-next-line @typescript-eslint/no-base-to-string
+
             thumbElement.src = file.data.toString();
             thumbElement.alt = file.name;
         } else {

diff --git a/lib/stacks.ts b/lib/stacks.ts
@@ -29,7 +29,7 @@ export class StacksApplication extends Stimulus.Application {
         schema?: Stimulus.Schema
     ): StacksApplication {
         const application = new StacksApplication(element, schema);
-        // eslint-disable-next-line @typescript-eslint/no-floating-promises
+
         application.start();
         return application;
     }
@@ -64,9 +64,9 @@ export class StacksController extends Stimulus.Controller {
                 cancelable: true,
                 detail: detail,
             });
-        } catch (ex) {
+        } catch {
             // Internet Explorer
-            // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
+
             event = document.createEvent("CustomEvent");
             event.initCustomEvent(namespacedName, true, true, detail);
         }

diff --git a/lib/test/test-utils.ts b/lib/test/test-utils.ts
@@ -119,7 +119,7 @@ type Themes = ["light" | "dark" | "highcontrast" | ""];
 
 const attrObjToString = (attrs: Record<string, string>): string => {
     const attrString = Object.keys(attrs).map((key) => {
-        return `${key}="${attrs[key]}"` || "";
+        return `${key}="${attrs[key]}"`;
     });
     return attrString.join(" ") || "";
 };