*******************************************************************************

Version 1.8.0

*******************************************************************************

2014-01-15 Peng <howtofly(at)gmail.com>

Fix memory leaks.

2013-04-27 Thijs Schreijer <thijs(at)thijsschreijer.nl>

Renamed SCRIPTSUPPORT to IXML_HAVE_SCRIPTSUPPORT for consistency. Also

updated autoconfig and automake files, so it also works on non-windows.

Option is enabled by default, because it adds an element to the node

structure. Not using an available field is better than accidentally

using an unavailable field.

2012-07-11 Thijs Schreijer <thijs(at)thijsschreijer.nl>

Changed param to const UpnpAcceptSubscriptionExt() for consistency

2012-06-07 Thijs Schreijer <thijs(at)thijsschreijer.nl>

updated ixmlDocument_createAttributeEx() and ixmlDocument_createAttribute()

to use parameter DOMString instead of char * (same but now consistent)

2012-05-06 Thijs Schreijer <thijs(at)thijsschreijer.nl>

Added script support (directive SCRIPTSUPPORT) for better support of

garbage collected script languages. The node element gets a custom tag

through ixmlNode_setCTag() and ixmlNode_getCTag(). And a callback upon

releasing the node resources can be set using ixmlSetBeforeFree()

See updated readme for usage.

2012-03-24 Fabrice Fontaine <fabrice.fontaine(at)orange.com>

SF Bug Tracker id 3510595 - UpnpDownloadXmlDoc : can't get the file

Submitted: Marco Virgulti ( mvirg83 ) - 2012-03-23 10:08:08 PDT

There is a problem, perhaps, during downloading a document by

UpnpDownloadXmlDoc. During debugging i've found that in an not exported

api (unfortunately i forgot the code line...) where it is setted a

local variable "int timeout" to -1 then passed directly to another

function for sending data through tcp socket. I patched this setting it

to 0 (there is an IF section that exits if timeout < 0). It is normal

behavior or it is a bug?

2012-03-08 Fabrice Fontaine <fabrice.fontaine(at)orange-ftgroup.com>

Check for NULL pointer in TemplateSource.h

calloc can return NULL so check for NULL pointer in CLASS##_new and

CLASS##_dup.

2012-03-08 Fabrice Fontaine <fabrice.fontaine(at)orange-ftgroup.com>

Replace strcpy with strncpy in get_hoststr

Replace strcpy with strncpy to avoid buffer overflow.

2012-03-08 Fabrice Fontaine <fabrice.fontaine(at)orange-ftgroup.com>

Memory leak fix in handle_query_variable

variable was never freed.

2011-02-07 Chandra Penke <chandrapenke(at)mcntech.com>

Add HTTPS support using OpenSSL. HTTPS support is optional and can

be enabled by passing the --enable-open-ssl argument to the

configure script.

The following methods are introduced to the public API:

UpnpInitOpenSslContext

When enabled, HTTPS can be used by using "https://" instead of

"http://" when passing URLs to the HTTP Client API.

2011-02-07 Chandra Penke <chandrapenke(at)mcntech.com>

Refactor HTTP Client API to be more generic.

The following features are added:

- Support for persistent HTTP connections (reusing HTTP

connections). Tthis is still a work in progress and relies on

applications to interpret the 'Connection' header

appropriately.

- Support for specifying request headers when making

requests. Useful for interacting with web services that require

custom headers.

- Support for retrieving response headers (this is a API only

change, some more work needs to be done to implement the actual

functionality. Specifically copy_msg_headers in httpreadwrite.c

needs to be implemented)

- Common API for all HTTP methods.

- Support for PUT, and DELETE methods.

The following methods are introduced to the public HTTP Client API

UpnpOpenHttpConnection, UpnpCloseHttpConnection, UpnpMakeHttpRequest,

UpnpWriteHttpRequest, UpnpEndHttpRequest, UpnpGetHttpResponse,

UpnpReadHttpResponse.

Removed a lot of duplicate code in httpreadwrite.c

2011-01-17 Chandra Penke <chandrapenke(at)mcntech.com>

Include upnpconfig.h in FileInfo.h to automatically include large

file macros

2011-01-17 Chandra Penke <chandrapenke(at)mcntech.com>

Fix for warnings Apple systems related to macros defined in list.h.

In list.h, in apple systems, undefine the macros prior to defining them.

2011-01-16 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

Fix for UpnpFileInfo_get_LastModified() in http_MakeMessage().

UpnpFileInfo_get_LastModified() returns time_t, and http_MakeMessage()

takes a "time_t *". Thanks to Chandra Penke for pointing the bug.

2010-11-22 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

Template object for ssdp_ResultData.

2010-11-10 Fabrice Fontaine <fabrice.fontaine(at)orange-ftgroup.com>

Support for "polling" select in sock_read_write.

Currently, in sock_read_write function, if the timeout is 0, pupnp

realizes a "blocking" select (with an infinite timeout). With this

patch, if timeout is set to 0, pupnp will realize a "polling" select

and returns immediately if it can not read or write on the socket. This

is very useful for GENA notifications when pupnp is trying to send

events to a disconnected Control Point. "Blocking" select can now be

done by putting a negative timeout value.

2010-09-18 Chandra Penke <chandrapenke(at)mcntech.com>

This is a minor build fix. The new Template*.h files added in the latest

code need to be exported. Patch against the latest sources is attached.

2010-08-22 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

* upnp/src/api/Discovery.c: Fix a serious bug and memory leak in

UpnpDiscovery_strcpy_DeviceType(). Thanks to David Blanchet for the

patch.

2010-04-25 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

Separation of the ClientSubscription object.

2010-04-24 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

Protect the object destructors agains null pointers on deletion, which

should be something valid.

2010-03-27 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

SF Patch Tracker [ 2987390 ] upnp_debug vs. ixml_debug

Thanks for the load of updates, I'm still assimilating them ! Could I make

a suggestion though? The addition of printNodes(IXML_Node) to upnpdebug a

dds a new dependency on ixml.h for anything using upnpdebug.h. I'm making

quite a bit of use of upnpdebug in porting things to version 1.8.0, and I'd

prefer it if printNodes could be added to ixmldebug.h instead. I'm attach

ing a patch, what do you think ?

Nick

2010-03-27 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

* Forward port of svn revision 505:

SF Patch Tracker [ 2836704 ] Patch for Solaris10 compilation and usage.

Submitted By: zephyrus ( zephyrus00jp )

2010-03-20 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

* SF Patch Tracker [ 2969188 ] 1.8.0: patch for FreeBSD compilation

Submitted By: Nick Leverton (leveret)

Fix the order of header inclusion for FreeBSD.

2010-03-20 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

* Forward port of svn revision 502:

SF Patch Tracker [ 2836704 ] Search for nested serviceList (not

stopping at the first lis

Submitted By: zephyrus ( zephyrus00jp )

Internet Gateway Device description contains nested serviceList (rootdevice

-> servicelist, subdevice

and subdevice has the lower-level serviceList, etc..)

Unfrotunately, the sample code sample_util.c used by tv_device sample,

etc.

has a code that looks for only the first top-level serviceList.

This results in the failure to read all the services of an IGD xml

description.

Attached patch modifies this behavior and looks for the service by

visiting all the serviceList in xml document in turn.

With the modified patch (ad additional modification), I could

simulate an IGD device and created a modified control program for that.

Patch against 1.6.6

TIA.

2010-03-20 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

* SF Patch Tracker [ 2973319 ] Problem in commit 499

Submitted By: Nick Leverton (leveret)

Afraid that this doesn't compile, it seems retval should be retVal in two

places.

2010-03-16 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

* Fix for the ithread_mutex_unlock() logic in UpnpInit().

Thanks for Nicholas Kraft.

2010-03-15 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

* SF Patch Tracker [ 2962606 ] Autorenewal errors: invalid SID,

too-short renewal interval

Submitted By: Nick Leverton (leveret)

Auto-renewals send an invalid SID due to a missing UpnpString_get_String

call. They also send a renewal interval of 0 instead of copying it from

the original subscription.

2010-03-15 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

* SF Patch Tracker [ 2964685 ] patch for avoiding inet_ntoa (1.8.0)

Submitted By: Nick Leverton (leveret)

Seems like SF's tracker won't let me add a patch to someone else's issue ?!

This refers to https://sourceforge.net/support/tracker.php?aid=2724578

The calls to inet_ntoa are in getlocalhostname(), which is called from

UpnpInit when it is returning the bound IP address.

UpnpInit/getlocalhostname hasn't been updated to IPv6, I presume this is

deliberate so that it doesn't start returning IPv6 addresses and

overwriting the caller's IPv4-sized allocation.

The attached patch just updates getlocalhostname to use inet_ntop instead

of inet_ntoa, and also documents the fact that UpnpInit is IPv4 only whilst

UpnpInnit2 is both IPv4 and IPv6.

A fuller solution might be to change UpnpInit to use some variant on

UpnpGetIfInfo. UpnpInit could still be left as IPv4 only if desired -

perhaps UpnpGetIfInfo could take an option for the desired address family.

getlocalhostname and its own copy of the interface scanning code would then

be redundant. I don't have IPv6 capability here though so I'm reluctant to

change the IPv6 code, as I have no way to test it.

2010-03-15 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

* SF Patch Tracker [ 2724578 ] patch for avoiding memory leaks when

add devices

each time a device been added, UpnpInit() is called, on exit, UpnpFinish()

is called, but the memories allocated by ThreadPoolInit() may lost because

there's no code to call ThreadPoolShutdown() to release the memories. And

inet_ntoa() is not thread safe, so in my patch, I substitute inet_ntoa()

with inet_ntop().

2010-03-14 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

* SF Patch Tracker [ 2964687 ] Add new string based accessors to upnp

object API

As per email to pupnp-devel, this is the patch to add the _strget_

accessors for string-like objects in the interface.

Will add a further patch shortly to udpate the sample programs.

2008-06-27 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

* Nicholas Kraft's patch to fix some IPv6 copy/paste issues. He

reported to be getting infinite loops with the svn code.

2008-06-13 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

* SF Bug Tracker [ 1984541 ]

ixmlDocumenttoString does not render the namespace tag.

Submitted By: Beliveau - belivo

Undoing the patch that fixed this problem. In fact, there was no

problem and the patch was wrong.

2008-06-11 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

* Ingo Hofmann's patch for "Content-Type in Subscription responses".

Adds charset="utf-8" attribute to the CONTENT-TYPE header line.

Hi,

I have found an inconsistency regarding the text/xml content-type

returned by libupnp. It looks like only subscription responses send

"text/xml" where all other messages contain "text/xml; charset="utf-8"".

Since I'm working on an DLNA device the latter behaviour is mandatory.

I changed the according lines in gena_device.c (see attached patch).

I'm not sure if it would be ok for other device to have the charset

field but it would help me a lot :)

Best regards,

Ingo

2008-06-04 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

* SF Bug Tracker [ 1984541 ]

ixmlDocumenttoString does not render the namespace tag.

Submitted By: Beliveau - belivo

The problem occurs when converting a xml document using

ixmlDocumenttoString containing a namespace tag created with

ixmlDocument_createElementNS. The namespace tag doesn't get rendered.

example: The following code fragment prints:

<?xml version="1.0"?>

<root></root>

instead of:

<?xml version="1.0"?>

<root xmlns="urn:schemas-upnp-org:device-1-0"></root>

Code:

#include <stdlib.h>

#include <upnp/ixml.h>

int main()

{

IXML_Document* wDoc = ixmlDocument_createDocument();

IXML_Element* wRoot = ixmlDocument_createElementNS(wDoc,

"urn:schemas-upnp-org:device-1-0", "root");

ixmlNode_appendChild((IXML_Node *)wDoc,(IXML_Node *)wRoot);

DOMString wString = ixmlDocumenttoString(wDoc);

printf(wString);

free(wString);

ixmlDocument_free(wDoc);

return 0;

}

The problem was in the printing routine, not in the library data

structure.

2008-05-31 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

* Charles Nepveu's suggestion of not allocating a thread for

MiniServer when it is not compiled.

2008-05-24 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

* Ported Peter Hartley's patch to compile with mingw.

2008-05-24 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

* Added some debug capability to ixml.

2008-05-02 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

* Merged Charles Nepveu's IPv6 work. libupnp now is IPv6 enabled.

2008-02-06 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

* Breaking API so that we now hide internal data structures.

2008-02-06 Marcelo Jimenez <mroberto(at)users.sourceforge.net>

* Rewrote Peter Hartley's patch to include a new extra header field in

FileInfo.

*******************************************************************************

Version 1.6.20

*******************************************************************************

2015-02-04 Shaun Marko <semarko@users.sf.net>

Bug tracker #124 Build fails with --enable-debug

Build environment

Fedora 21

X86-64

* gcc 4.9.2

How to repeat

$ ./configure --enable debug

$ make

libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I../upnp/inc -I./inc -I../threadutil/inc

-I../ixml/inc -I./src/inc -pthread -g -O2 -Wall -MT src/api/libupnp_la-UpnpString.lo

-MD -MP -MF src/api/.deps/libupnp_la-UpnpString.Tpo -c src/api/UpnpString.c

-fPIC -DPIC -o src/api .libs/libupnp_la-UpnpString.o src/api/UpnpString.c:47:16:

error: expected identifier or '(' before 'extension'

extern char *strndup(const char *string, size_t __n);

^

Makefile:1016: recipe for target 'src/api/libupnp_la-UpnpString.lo' failed

Reason for failure

Build enables -O2 optimization flags which causes the inclusion of a

macro implementation of strndup from include/bits/string2.h.

Workarounds

Disable optimization when configuring or making:

$ configure CFLAGS='-g -pthread -O0' --enable-debug

$ make

or

$ configure --enable-debug

$ make CFLAGS='-g -pthread -O0' Define NO_STRING_INLINES

$ export CFLAGS="-DNO_STRING_INLINES -O2"

$ ./configure --enagble-debug

$ make

Fix

* Don't declare strndup in src/api/UpnpString.c if it exists

2015-02-01 Jean-Francois Dockes <medoc@users.sf.net>

Out-of-tree builds seem to be currently broken, because ixml and

threadutil files need an include path to include UpnpGlobal.h, and

configure tries to copy files into a directory which it does not create.

The patch fixes both issues.

2014-01-03 Peng <howtofly(at)gmail.com>

rewrite soap_device.c

1) separate HTTP handling from SOAP handling

2) remove repeated validity check, each check is performed exactly once

3) fix HTTP status code per UPnP spec, SOAP spec and RFC 2774

*******************************************************************************

Version 1.6.19

*******************************************************************************

2013-11-14 Marcelo Roberto Jimenez <mroberto(at)users.sourceforge.net>

SF Bug Tracker #119, Creator: Klaus Fischer

Access violation due to changed usage of pthreads-win32

Dear libupnp developers,

I have experienced a crash (access violation) when using libupnp on

Windows. The crash is actually located in pthreads-win32 and happens

when repeatedly de-/initializing libupnp on Win32 in the same process

and both libupnp and pthreads-win32 are compiled as static libraries.

So I'm doing this:

- UpnpInit()

- UpnpFinish()

- UpnpInit() <- Crash

I am already in touch with Ross Johnson on the pthreads-win32 mailing

list regarding this issue:

http://sourceware.org/ml/pthreads-win32/2013/msg00020.html

He told me the problem is that the functions

pthread_win32_process_attach/detach_np() should no longer be called

directly, but are invoked automatically now since version 2.9.0 of

pthreads-win32, which has been released approx. 1.5 years ago. Please

refer to above link for in-depth information.

So for proper using of latest pthreads-win32 library, those function

calls should vanish inside libupnp. Could you consider adapting libupnp

in that way? I would really like to use both libraries out-of-the-box

without local modifications, and this issue prevents that.

Best regards,

Klaus

2013-11-08 Peng <howtofly(at)gmail.com>

Fix several minor bugs in soap_device.c

1) remove redundant free

2) avoid user-provided ErrStr being overwritten by the default one

3) eliminated memory leak possiblity in handle_query_variable

2013-11-08 Peng <howtofly(at)gmail.com>

Fix return value check of parse_uri.

2012-06-19 Yoichi NAKAYAMA <yoichi.nakayama(at)gmail.com>

SF Bug Tracker #118, Creator: T.Iwamoto

tv_ctrlpt crashes after detecting a later version of tvcontrol service

From: gon3456@users.sf.net

Steps to reproduce:

1. Extracts and build libupnp-1.6.18

$ tar -xjf /path/to/archive/libupnp-1.6.18.tar.bz2

$ cd libupnp-1.6.18

$ ./configure

$ make

2. Applies the attached patch and remake.

$ patch -p1 < /path/to/patch/libupnp-1.6.18.patch

$ make

3. Run tv_device.

$ cd upnp/sample

$ ./tv_device

4. Run tv_ctrlpt; the tv_ctrlpt crashes soon.

$ ./tv_ctrlpt

Segmentation fault (core dumped)

This is an issue report about the sample program of control point.

The tv_ctrlpt crashes after detecting a tvdevice that contains tvcontrol:2 or higher version of tvcontrol service.

tv_ctrlpt should detect correctly such devices due to forward compatibility of control points with device.

For more information about the compatibility, please refer the following document:

DLNA Architectures and Protocols Part 1 2011 December - 7.3.2.1.3 (GUN:GZJXU)

The attached patch changes the sample programs as below:

- device: changes version of tvcontrol service from 1 to 2. This change may occur in the future.

- cp: nothing changed: cp knows version 1 of tvcontrol service only.

I know many vendors implements their control points based on the tv_ctrlpt, so I hope to fix this issue ASAP.

==

From: Yoichi NAKAYAMA

SEGV is caused by strcpy with NULL argument.

Attached patch will avoid SEGV in strcpy, but there may be other inconsistencies.

> I know many vendors implements their control points based on the tv_ctrlpt,

I don't think so. I think tv_ctrlpt is just a sample to be used with tv_device.

2013-10-28 Pino Toscano <pinotree(at)users.sourceforge.net>

Fix compilation on GNU/Hurd

2013-10-28 Peng <howtofly(at)gmail.com>

Fix return value of http_RecvPostMessage and update httpparser.c's comments

2013-10-17 Peng <howtofly(at)gmail.com>

Fix return value of process_request and related subroutines

1) Only HTTP_XXX should be return

2) Make default return value work for process_request

2013-10-15 Peng <howtofly(at)gmail.com>

Fix Content-Range generation bug

2013-09-10 zexian chen <chenzexian88(at)gmail.com>

Hi,

I had found some bugs about memory leak on libupnp-1.6.18.

It may lead to memory leak when calling ThreadPoolAdd() or

ThreadPoolAddPersistent() which does not return 0.

See the attachment for patch.

2013-09-03 Peng <howtofly(at)gmail.com>

Fix return value of config_description_doc.

UPNP_E_XXX should not be used instead of IXML_XXX

2013-09-03 Peng <howtofly(at)gmail.com>

Remove faulty free in GetDescDocumentAndURL.

temp_str, which points to part of description, should not be freed.

2013-09-02 Peng <howtofly(at)gmail.com>

Suppose the UPnP device is listening on 192.168.1.102:49152. Use the following to send

garbage bytes to the device:

while true; do echo "\""; done | netcat 192.168.1.102 49152

The device just keeps receiving these bytes and its memory usage keeps growing.

Malicious client may exploit it to exhaust the device's memory.

The attached patch eliminates this possibility.

2013-09-02 Peng <howtofly(at)gmail.com>

1) restore the scanner's original cursor position in case of

insufficient input;

2) free the memories allocated for a new header in case of a failure.

2013-08-13 Peng <howtofly(at)gmail.com>

Patch to fix behaviou when char is signed

it seems to me that there is still something wrong:

1) the new is_qdtext_char() is incorrect.

There is a trap if char is implemented as signed char.

Suppose that c is '\xFF', it will be -1 when converted to an int.

By definition, c should be qdtext:

qdtext = <any TEXT except <">>

TEXT = <any OCTET except CTLs, but including LWS>

OCTET = <any 8-bit sequence of data>

2) the character after '\\' could be either part of a quoted-pair

(together with '\\'), or a normal qdtext, since '\\' itself can

be treated as a qdtext. This is equivalent to saying that the

character after '\\' in a quoted string could be ANY octet.

A patch based on the above two observations is attached.

Peng

2013-08-13 Marcelo Roberto Jimenez <mroberto(at)users.sourceforge.net>

Enforce RFC 2616 and accept "0" after a backslash for quoted-strings.

Reported by Peng <howtofly(at)gmail.com>

2013-08-13 Peng <howtofly(at)gmail.com>

Patch to make scanner_get_token more robust (avoid over-reading).

2013-07-30 Zheng Peng <darkelf2010(at)users.sf.net>

SF ticket #116 UpnpRemoveVirtualDir wrong linked list operation

What if pVirtualDirList has two nodes and what we want to delete is the

first one. Patch attached.

2013-07-30 Sebastian Brandt <s.brandt(at)aixtrusion.de>

Dear libupnp-devels,

when POST'ing to the simple web server in libupnp, the application crashes.

This is caused by a missing "..." argument in webserver.c:1533.

Seems it has been there for a long time ... 1.6.9 and 1.6.18 have it.

webserver.c:1533 calls http_MakeMessage

/* Send response. */

http_MakeMessage(&headers, 1, 1,

"RTLSXcCc",

ret, "text/html", X_USER_AGENT);

The format parameter RTLSXcCc needs four arguments -

R - response code - ret,

T- content type - text/html,

L - struct SendInstruction * - NOT PRESENT

X - user agent - X_USER_AGENT

This results in a crash.

Changing to

http_MakeMessage(&headers, 1, 1,

"RTLSXcCc",

ret, "text/html", &RespInstr, X_USER_AGENT);

solves the situation.

Yours,

Sebastian Brandt

*******************************************************************************

Version 1.6.18

*******************************************************************************

2012-12-06 Marcelo Roberto Jimenez <mroberto(at)users.sourceforge.net>

Security fix for CERT issue VU#922681

This patch addresses three possible buffer overflows in function

unique_service_name(). The three issues have the folowing CVE numbers:

CVE-2012-5958 Issue #2: Stack buffer overflow of Tempbuf

CVE-2012-5959 Issue #4: Stack buffer overflow of Event->UDN

CVE-2012-5960 Issue #8: Stack buffer overflow of Event->UDN

Notice that the following issues have already been dealt by previous

work:

CVE-2012-5961 Issue #1: Stack buffer overflow of Evt->UDN

CVE-2012-5962 Issue #3: Stack buffer overflow of Evt->DeviceType

CVE-2012-5963 Issue #5: Stack buffer overflow of Event->UDN

CVE-2012-5964 Issue #6: Stack buffer overflow of Event->DeviceType

CVE-2012-5965 Issue #7: Stack buffer overflow of Event->DeviceType

2012-06-19 Yoichi NAKAYAMA <yoichi.nakayama(at)gmail.com>

Fix memory leak and access violation in UpnpSendAction(Ex)Async.

Free buffers after malloc or ixmlPrintNode failure.

Free Param->Header before destructing Param.

2012-05-25 Anoop Mohan <anoop.anoop(at)gmail.com>

This patch fixes a bug in non blocking connect call where the sock

option length for SO_ERROR was passed as 0 instead of sizeof(int).

2012-04-24 Yoichi NAKAYAMA <yoichi.nakayama(at)gmail.com>

Disable SetGenaCallback call if device is disabled.

If device is disabled, SetGenaCallback definition is disabled,

but its call remains. A link error will occur in Win32.

2012-04-21 Yoichi NAKAYAMA <yoichi.nakayama(at)gmail.com>

Fix condition for allocation failure in get_content_type().

At the end of get_content_type() in webserver.c, it should check

return value of ixmlCloneDOMString().

2012-04-21 Yoichi NAKAYAMA <yoichi.nakayama(at)gmail.com>

Fix problems detected as dead assignment warning by clang scan-build.

Wrong assignment by shutdown result hides the real error code

of NewRequestHandler() in ssdp_device.c.

Fix return code description of NewRequestHandler().

Handle return code from ithread_create in sample applications.

Remove unused assignments.

2012-04-20 Yoichi NAKAYAMA <yoichi.nakayama(at)gmail.com>

Avoid dereference of null pointer in ixmlNode_setNodeProperties.

The problem can occur if one of the arguments is NULL.

Test argument and fix assertion.

2012-04-17 Yoichi NAKAYAMA <yoichi.nakayama(at)gmail.com>

Create intermediate directory per project on vc9.

Sample applications share sample_util.c and collisions of

object file can occur in parallel build. Modify project files to

split intermediate directories against it.

Apply similar changes also to library projects, like vc10 projects.

2012-04-11 Yoichi NAKAYAMA <yoichi.nakayama(at)gmail.com>

Avoid access violation after parser_parse_chunky_headers call.

In parser_parse_chunky_headers, parser->msg.msg.buf can be changed

by membuffer_delete call. Therefore if we save the pointer to

parser->msg.entity.buf before calling membuffer_delete, it will

induce access to released memory.

2012-04-06 Yoichi NAKAYAMA <yoichi.nakayama(at)gmail.com>

Remove possibility of access violation.

1. Test Instr before dereference it in http_RecvPostMessage.

(Though it never becomes NULL because NULL is not passed to

the static method)

2. Avoid strdup(NULL) in ixmlElement_setAttributeNS.

Those are detected by llvm scan-build.

2012-04-05 Yoichi NAKAYAMA <yoichi.nakayama(at)gmail.com>

SF Bug Tracker id 3507819 - Use of thread-unsafe gmtime() in httpreadwrite.c

Submitted: zephyrus ( zephyrus00jp ) - 2012-03-18 06:31:00 PDT

Define http_gmtime_r and web_server_asctime_r and use it.

Those prefix are added since pthread for Win32 already

has macro gmtime_r and asctime_r.

2012-04-05 Yoichi NAKAYAMA <yoichi.nakayama(at)gmail.com>

Fix type of local variable stopSock in RunMiniServer()

The variable is declared as SOCKET, but it is used to

store return value of int receive_from_stopSock(...).

The type was changed in the commit

4b47e6a51d9c7049a862695b68de75699e023551 by mistake.

2012-04-03 Fabrice Fontaine <fabrice.fontaine(at)orange.com>

Compilation optimisation

Do not compile the code related to the webserver in http_SendMessage

when --disable-webserver is set

*******************************************************************************

Version 1.6.17

*******************************************************************************

2012-04-02 Fabrice Fontaine <fabrice.fontaine(at)orange.com>

SF Bug Tracker id 3514145 - Memory leak fix in threadutil

Submitted: Fabrice Fontaine ( ffontaine ) - 2012-04-02 06:49:20 PDT

Put thread in a detached state when calling ithread_create otherwise in

some circumstances, thread can end before the call to ithread_detach.

2012-03-30 Fabrice Fontaine <fabrice.fontaine(at)orange.com>

Add --enable-unspecified_server

Add --enable-unspecified_server configure option to set to "Unspecified"

the OS name, OS version, product name and product version normally

contained in the SERVER header as this could be used by an attacker.

2012-03-29 Fabrice Fontaine <fabrice.fontaine(at)orange.com>

Removing implicit casts in miniserver.c

Removing implicit integer or enum casts in miniserver.c.

2012-03-29 Fabrice Fontaine <fabrice.fontaine(at)orange.com>

SF Bug Tracker id 3512833 - Miniserver is wrongly disabled

Submitted: Fabrice Fontaine ( ffontaine ) - 2012-03-29 07:36:34 PDT

Miniserver is disabled if ECXLUDE_GENA, EXCLUDE_SOAP and

EXCLUDE_WEBSERVER are set.

However, SSDP needs the Miniserver to answer to M-SEARCH requests.

So, MiniServer should not be disabled if EXCLUDE_SSDP is not also set.

2012-03-26 Yoichi NAKAYAMA <yoichi.nakayama(at)gmail.com>

SF Bug Tracker id 3510693 - build fail with --disable-device

Use INCLUDE_DEVICE_APIS instead of UPNP_HAVE_DEVICE as in other sources.

Don't use soap_device_callback if INCLUDE_DEVICE_APIS is not set,

otherwise link error occur on Windows.

2012-03-26 Fabrice Fontaine <fabrice.fontaine(at)orange.com>

SF Bug Tracker id 3511149 - --disable-ssdp has no effect

Submitted: Yoichi NAKAYAMA ( yoichi ) - 2012-03-25 18:14:34 PDT

There are typos in upnp/src/inc/config.h "EXCLUDE_SSSDP" (shold be

EXCLUDE_SSDP), therefore EXCLUDE_SSDP is always 0, and --disable-ssdp

has no effect.

2012-03-24 Fabrice Fontaine <fabrice.fontaine(at)orange.com>

Remove implicit casts

Cast parameters of htonl in uint32_t in IN6_IS_ADDR_GLOBAL and

IN6_IS_ADDR_ULA definitions.

Remove comparison with 0 in while statement of vfmatch,

http_SendMessage and http_MakeMessage.

2012-03-24 Yoichi NAKAYAMA <yoichi.nakayama(at)gmail.com>

SF Bug Tracker id 3510693 - build fail with --disable-device

GetDeviceHandleInfo just fail without using undefined member DeviceAf

if UPNP_HAVE_DEVICE is not defined.

Move ContentTypeHeader definition to soap_common.c, since it is

also used in soap_ctrlpt.c.

*******************************************************************************

Version 1.6.16

*******************************************************************************

2012-03-18 Fabrice Fontaine <fabrice.fontaine(at)orange.com>

Replace sprintf by snprintf in http_WriteHttpPost

Replace sprintf by snprintf in http_WriteHttpPost to avoid buffer

overflow.

2012-03-18 Fabrice Fontaine <fabrice.fontaine(at)orange.com>

Add infoSize parameter to get_sdk_info

Add infoSize parameter to get_sdk_info function to replace sprintf call

by a snprintf call.

2012-03-16 Fabrice Fontaine <fabrice.fontaine(at)orange.com>

Check return code in ixml

Check return code of ixmlDocument_CreateElementEx in

ixmlDocument_CreateElement.

Check return code of ixmlNode_setNodeName and ixmlNode_setNodeValue in

ixmlNode_cloneCDATASect and ixmlNode_cloneTextNode.

2012-03-16 Fabrice Fontaine <fabrice.fontaine(at)orange.com>

Add more explicit casts and remove dead code

Comment unused SERVER from DeviceShutdown.

Comment unused max from parse_hostport.

Comment unused nodeptr from ixmlNode_cloneDoc.

Comment unused newNode from Parser_hasDefaultNamespace.

Comment unused Parser_parseReference function

Check return code of shutdown and display an error if needed.

2012-03-15 Fabrice Fontaine <fabrice.fontaine(at)orange.com>

Fix previous commit

Replace HAVE_UPNP_OPTSSDP by UPNP_HAVE_OPTSSDP in upnpapi.c.

2012-03-15 Fabrice Fontaine <fabrice.fontaine(at)orange.com>

Add --disable-optssdp option

Modify configure.ac to add --disable-optssdp option. This option will

remove OPT, 01-NLS and X_USER_AGENT headers from SSDP messages as those

headers are optional. If --disable-gena and disable-optssdp are both

used, uuid part will not be compiled anymore.

2012-03-15 Fabrice Fontaine <fabrice.fontaine(at)orange.com>

Bug fix in ixmlNode_allowChildren

Commit d48d73720bd325062c4d3b9ce85f3944be4f562d added a bug in

ixmlNode_allowChildren, this function was returning FALSE instead of

TRUE when newChild->nodeName was eELEMENT_NODE.

2012-03-15 Fabrice Fontaine <fabrice.fontaine(at)orange.com>

Improve upnp/genlib/net

Change ret_code from int to parse_status_t in match.

Set back return code of ReadResponseLineAndHeaders from parse_status_t

to int as this function can return UPNP_E_BAD_HTTPMSG. As a result, do

not cast the result of this function into parse_status_t in

http_OpenHttpGetProxy and http_OpenHttpGetEx.

Use switch with PARSE_OK in parsetools.c.

Add missing explicit casts of integer constants in uri.c and

httpreadwrite.c.

Use switch, int and sa_family_t with AF_INET in uri.c.

Print an error in http_Download if realloc failed.

2012-03-14 Fabrice Fontaine <fabrice.fontaine(at)orange.com>

Use switch instead of if with enums in upnpapi.c

Replace if statements with switch when using HND_DEVICE and HND_CLIENT

enum constants.

Correct also UpnpUnRegisterRootDeviceLowPower and UpnpUnRegisterClient

as those functions were wrongly awaiting an UPNP_E_INVALID_HANDLE

instead of HND_INVALID from GetHandleInfo.

2012-03-14 Fabrice Fontaine <fabrice.fontaine(at)orange.com>

Improve ssdp part

Do not compile CreateClientRequestPacketUlaGua if IPv6 is disable.

Cast DestAddr->sa_family from sa_family_t into int when calling

CreateServicePacket as this function has been set back to accept int in

a692e591defe6ed9a617b9b4a083964a01f7bbab.

Use switch instead of if with AF_INET and AF_INET6.

Add missing casts from AF_INET and AF_INET6 into sa_family_t when using

them to set sin_family and sin6_family.

Add missing explicit casts into size_t or lu when using integer

constants with strlen or unsigned long indexes.

Set SSDP_PAUSE to be unsigned as it is used with usleep.

2012-03-14 Fabrice Fontaine <fabrice.fontaine(at)orange.com>

Use switch insted of if with enums in ixml

Replace if statements with switch when using enums in ixml.

Remove uneeded initialization in ixmlAttr_init, Parser_init and

ixmlNode_init which was added by wrongly added in commit

06660b6383c438e4e2c9ca9854077cecc4da9e5d.

2012-03-14 Fabrice Fontaine <fabrice.fontaine(at)orange.com>

Use switch insted of if with enums in threadutil

Replace if statements with switch when using enums in threadutil.

2012-03-14 Fabrice Fontaine <fabrice.fontaine(at)orange.com>

Fix missing break in http_RecvMessage

There was a missing break in PARSE_INCOMPLETE_ENTITY due to commit

2eb3e069badd5c8676738c3ead37f9551fd8448e.

2012-03-14 Yoichi NAKAYAMA <yoichi.nakayama(at)gmail.com>

Fix parse failure observed with tvdevice sample.

Commit c40d2bc0c9b60c43b641ac4669c7b8bbcd6134c5 has a problem

at removing the parentheses in parser_parse_responseline.

Difference of pointers was used with intention, don't cast

them separately.

2012-03-14 Yoichi NAKAYAMA <yoichi.nakayama(at)gmail.com>

Fix compile error on Windows.

Include UpnpStdInt.h for ssize_t.

Define sa_family_t in UpnpInet.h.

2012-03-14 Yoichi NAKAYAMA <yoichi.nakayama(at)gmail.com>

Avoid ambiguous change of SsdpEvent in unique_service_name.

Handle overflow before changing SsdpEvent.

Because the behavior of "snprintf" is platform dependent in such case.

2012-03-14 Yoichi NAKAYAMA <yoichi.nakayama(at)gmail.com>

SF Bug Tracker id 3502958 - The commit 5944960e prevents a pupnp client (amule) from receiving replies from an IGD device.

Previous change broke the feature. The error of unique_service_name

in ssdp_request_type should be ignored.

This reverts commit 5944960e172a797a9fcc196291f4046cafa7f6ec.

2012-03-13 Marcelo Roberto Jimenez <mroberto(at)users.sourceforge.net>

Address family is an int

Reference: "man 2 socket".

2012-03-11 Fabrice Fontaine <fabrice.fontaine(at)orange.com>

Remove more implicit casts in upnp part

Remove more "implicit integer or enum conversions" errors as well as

dead code.