tweak(ymap): dont limit ymap entities to drawables #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theres no reason to limit ymap entities to only drawable objects, fragments exist, and also its much easier to work with unparented meshes (just a drawable model) if you have many instances of this model, rather than have it parented to a drawable for it to export properly.
|
There is also the entity properties panel that is only shown for drawables. But I guess I can merge this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
theres no reason to limit ymap entities to only drawable objects, fragments exist, and also its much easier to work with unparented meshes (just a drawable model) if you have many instances of this model, rather than have it parented to a drawable for it to export properly.