Customer Eval Starter Code #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-tzayats
requested review from
sfc-gh-rehuang,
sfc-gh-cnivera and
sfc-gh-jsummer
as code owners
sfc-gh-tzayats
force-pushed
the
customer-eval
branch
from
15fe4b1 to
a61485e
Compare
sfc-gh-jsummer
approved these changes
Jan 17, 2025
| @@ -56,7 +56,7 @@ run_isort: ## Run isort to update imports. | |||
|
|
|||
|
|
|||
| fmt_lint: shell ## lint/fmt in current python environment | |||
| make run_mypy run_black run_isort run_flake8 | |||
There was a problem hiding this comment.
any reason we're removing mypy?
There was a problem hiding this comment.
its not currently checked as part of linting.
We can add it if we fix the warning.. but did not want to include extra unnecessary changes to unrelated files.
sfc-gh-kschmaus
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer Eval Branch
Merging to main to avoid maintaining custom branch.