Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend require section of composer.json with maximum compatibility version #2023

Open
mamsincl opened this issue Dec 14, 2020 · 3 comments
Open

Comments

@mamsincl
Copy link

Is your feature request related to a problem? Please describe.
During and (especially) after Magento upgrade (via composer) the incompatibility with the previous Elasticsuite version could cause unexpected behaviour. Debugging the issue could be time-consuming and may result custom patches and unnecessary PRs

Describe the solution you'd like
Extend compatible version with maximum version in require section of composer.json

Describe alternatives you've considered
We can call the beginning of README as an alternative solution already exists

Additional context
example for version 2.9.x (compatible with Magento >=2.3.5 <2.4.0 - linking to magento/framework should be enough):

"require": {
        "magento/framework": ">=102.0.5 <103.0.0",
        "magento/module-store": ">=101.0.5",
        "magento/module-backend": ">=101.0.5",
        "magento/module-catalog": ">=103.0.5",
        "magento/module-catalog-search": ">=101.0.5",
        "magento/module-catalog-graph-ql": ">=100.3.5",
        "magento/module-inventory-sales-api": ">=1.0.3",
        "magento/module-inventory-sales": ">=1.0.3",
        "magento/module-inventory-indexer": ">=1.0.3",
        "magento/magento-composer-installer": "*",
        "elasticsearch/elasticsearch": "~6.7|~7.2"
    },
@romainruaud
Copy link
Collaborator

Yep, I do agree with this, it would also save us some time answering on "invalid" issues here that are due to misfits with maximum supported versions.

@mamsincl
Copy link
Author

I'll see if I can spare some time to help with this ...
Can you advise on the best approach of MRs?

@romainruaud
Copy link
Collaborator

@mamsincl you can propose a PR to 2.9.x and 2.10.x branch

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants