Skip to content

Add new environment variable for public version of SKYGEAR_ENDPOINT #232

Open
@carmenlau

Description

Currently we used SKYGEAR_ENDPOINT as default of pubsub and skygear container endpoint in py-skygear, so I assume that SKYGEAR_ENDPOINT should be the skygear server endpoint in the private network. But for some cases like generating reset password link. We will want to have a public version of skygear server endpoint. So I suggest that we should have both public and private version of skygear endpoint config in py-skygear so we can use them in different case. If my assumption of "SKYGEAR_ENDPOINT should be private" is correct, maybe we can add SKYGEAR_PUBLIC_ENDPOINT?

Note: After we updated, we should also update plugins default. For example, skygear-sso callback url default, forgot_password reset password, verify url default... etc.

  • Skygear Server Date/Version: 1.6.1
  • Application Platform:
  • Is this a regression?
  • Attached logs, screenshots

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions