Clean up background index check

SixLabors · Nov 20, 2024 · 4596511 · 4596511
1 parent b4567a4
commit 4596511
Showing 1 changed file with 19 additions and 13 deletions.
diff --git a/src/ImageSharp/Formats/Gif/GifEncoderCore.cs b/src/ImageSharp/Formats/Gif/GifEncoderCore.cs
@@ -156,12 +156,7 @@ public void Encode<TPixel>(Image<TPixel> image, Stream stream, CancellationToken
             frameMetadata.TransparencyIndex = ClampIndex(derivedTransparencyIndex);
         }
 
-        byte backgroundIndex;
-        if (this.backgroundColor.HasValue)
-        {
-            backgroundIndex = GetBackgroundIndex(quantized, this.backgroundColor.Value);
-        }
-        else
+        if (!TryGetBackgroundIndex(quantized, this.backgroundColor, out byte backgroundIndex))
         {
             backgroundIndex = derivedTransparencyIndex >= 0
                ? frameMetadata.TransparencyIndex
@@ -510,15 +505,19 @@ private static int GetTransparentIndex<TPixel>(IndexedImageFrame<TPixel>? quanti
     /// </summary>
     /// <param name="quantized">The current quantized frame.</param>
     /// <param name="background">The background color to match.</param>
+    /// <param name="index">The index in the palette of the background color.</param>
     /// <typeparam name="TPixel">The pixel format.</typeparam>
-    /// <returns>The <see cref="byte"/>.</returns>
-    private static byte GetBackgroundIndex<TPixel>(IndexedImageFrame<TPixel>? quantized, Color background)
+    /// <returns>The <see cref="bool"/>.</returns>
+    private static bool TryGetBackgroundIndex<TPixel>(
+        IndexedImageFrame<TPixel>? quantized,
+        Color? background,
+        out byte index)
         where TPixel : unmanaged, IPixel<TPixel>
     {
-        int index = -1;
-        if (quantized != null)
+        int match = -1;
+        if (quantized != null && background.HasValue)
         {
-            TPixel backgroundPixel = background.ToPixel<TPixel>();
+            TPixel backgroundPixel = background.Value.ToPixel<TPixel>();
             ReadOnlySpan<TPixel> palette = quantized.Palette.Span;
             for (int i = 0; i < palette.Length; i++)
             {
@@ -527,12 +526,19 @@ private static byte GetBackgroundIndex<TPixel>(IndexedImageFrame<TPixel>? quanti
                     continue;
                 }
 
-                index = i;
+                match = i;
                 break;
             }
         }
 
-        return (byte)Numerics.Clamp(index, 0, 255);
+        if (match >= 0)
+        {
+            index = (byte)Numerics.Clamp(match, 0, 255);
+            return true;
+        }
+
+        index = 0;
+        return false;
     }
 
     /// <summary>