Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for new override labels #527

Merged
merged 10 commits into from
Feb 28, 2023
Merged

support for new override labels #527

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
486eb78
remove refs to old annotations
dani-santos-code Feb 23, 2023
8e7f14f
add logic to make it backwards compat with tests
dani-santos-code Feb 23, 2023
1ed38ae
add deprecation warning
dani-santos-code Feb 24, 2023
37523c1
add notes in the doc
dani-santos-code Feb 24, 2023
913ec0b
test removing the test temporarily
dani-santos-code Feb 24, 2023
7d5b684
renames namespaces
dani-santos-code Feb 24, 2023
eba0895
feedback: fix test
dani-santos-code Feb 27, 2023
896f2b6
genevive's feedback: clean up annotations
dani-santos-code Feb 27, 2023
154ada6
Update auditors/apparmor/fixtures/apparmor-bad-value-override.yml
dani-santos-code Feb 27, 2023
211c9a8
feedback - remove deprecation option
dani-santos-code Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add notes in the doc
  • Loading branch information
@dani-santos-code
dani-santos-code committed Feb 24, 2023
commit 37523c16d958afd4ccb5e5f14b6e1dcb06dae269
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

> It is now a requirement for clusters to run Kubernetes >=1.19.

> override labels with unregistered `kubernetes.io` annotations will be deprecated. It'll soon be a requirement to use `kubeaudit.io` instead.
Refer to this [discussion](https://github.com/Shopify/kubeaudit/issues/457) for additional context.
dani-santos-code marked this conversation as resolved.
Show resolved Hide resolved

# kubeaudit :cloud: :lock: :muscle:

Expand Down
2 changes: 1 addition & 1 deletion auditors/apparmor/fixtures/apparmor-disabled-overriden-old-label.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: v1
kind: Pod
metadata:
name: pod
namespace: apparmor-disabled-overriden
namespace: apparmor-disabled-overriden-old
annotations:
container.apparmor.security.beta.kubernetes.io/container: unconfined
labels:
Expand Down