Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: Add a logging abstraction and wrap remix build output to track errors #941

Closed
wants to merge 4 commits into from
Closed

PoC: Add a logging abstraction and wrap remix build output to track errors #941

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ee7385
Add a logging abstraction and wrap remix build output to track errors
blittle May 24, 2023
c3f8eee
Log errors from deferred data
frandiox May 26, 2023
e8ce52b
Inline Logger type
frandiox May 26, 2023
3711b80
Remove kolorist
frandiox May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Inline Logger type
  • Loading branch information
@frandiox
frandiox committed May 26, 2023
commit e8ce52be310868f85b4d7bdc669d0ce3b859168c
3 changes: 2 additions & 1 deletion packages/remix-oxygen/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ import {
type ServerBuild,
} from '@remix-run/server-runtime';
import {isDeferredData} from '@remix-run/server-runtime/dist/responses';
import type {Logger} from '@shopify/hydrogen';

type Logger = {error: (...data: any[]) => any};

export function createRequestHandler<Context = unknown>({
build,
Expand Down