Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mouse click effect capability for screen recording #7622

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
+379 −38
Open

Add mouse click effect capability for screen recording #7622

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bc48eac
add mouse click effect capability for screen recording
Vertygo Oct 2, 2024
dd383c8
review: switch to full circle
Vertygo Oct 2, 2024
b206d5e
review: switch to layered window
Vertygo Oct 3, 2024
95c9174
run effect outside Task.Run
Vertygo Oct 13, 2024
30cb81d
adhere to coding guidelines - removing underscore from fields
Vertygo Oct 13, 2024
582d793
implement right click effect
Vertygo Oct 13, 2024
57b1be0
fix checkbox position in settings form
Vertygo Oct 13, 2024
e45f45d
fix formatting
Vertygo Oct 15, 2024
28c4c56
add space in control flow statement option in .editorconfig
Vertygo Oct 15, 2024
5ac1d29
removing empty lines
Vertygo Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix formatting
  • Loading branch information
@Vertygo
Vertygo committed Oct 15, 2024
commit e45f45d2929d604996793a88bfb0f65bf29ec809
8 changes: 4 additions & 4 deletions ShareX/ScreenRecordManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,9 @@ public static void AbortRecording()
recordForm.AbortRecording();
}

if (IsRecording && mouseClickEffectManager != null)
if (IsRecording)
{
mouseClickEffectManager.Stop();
mouseClickEffectManager?.Stop();
}
}

Expand Down Expand Up @@ -277,7 +277,7 @@ private static void StartRecording(ScreenRecordOutput outputType, TaskSettings t
}

recordForm.ChangeState(ScreenRecordState.AfterStart);
mouseClickEffectManager.Resume();
mouseClickEffectManager?.Resume();

captureRectangle = recordForm.RecordingRegion;

Expand Down Expand Up @@ -350,7 +350,7 @@ private static void StartRecording(ScreenRecordOutput outputType, TaskSettings t
screenRecorder = null;
}

if(mouseClickEffectManager != null)
if (mouseClickEffectManager != null)
{
mouseClickEffectManager.Stop();
mouseClickEffectManager = null;
Expand Down