Add mouse click effect capability for screen recording #7622
Conversation
Vertygo
changed the title
Vertygo
force-pushed
the
mouse-click-effect
branch
from
eea26e7 to
bc48eac
Compare
| int y = (ClientSize.Height - diameter) / 2; | ||
|
|
||
| // .NET GDI+ is not precise when drawign circles this would be better off with WPF/vector-based drawing | ||
| g.DrawEllipse(pen, x, y, diameter, diameter); |
There was a problem hiding this comment.
This might not be best solution due to GDI+ poor precision.
There was a problem hiding this comment.
I can't add that much to this, I just wanted to say that rn I'm using this tool https://github.com/Phaiax/Key-n-Stroke to achieve the same and as it is open-source already you guys can probably get inspiration from there and/or took over some of the code to not reinvent the wheel here :) (altho I dunno if the poor precision thing is really better with keynstroke --> at least from a enduser-experience I've never had simliar problems)
There was a problem hiding this comment.
Good point @saintcore. I do get inspired by projects like this. I like keyboard capturing capability it has and I might take a stab at it after I'm done with mouse effect.
I don't know how things work regarding "taking over" some code in the open-source world. I guess some collaboration with the owner (@Phaiax) is needed.
Regarding the small issue I mentioned here, I think that might be solved with help from @Jaex but keynstroke uses WPF so it is slightly different than ShareX which uses Windows Forms.
There was a problem hiding this comment.
Well according to the provided license, it shouldn't be a problem (see https://github.com/Phaiax/Key-n-Stroke?tab=Apache-2.0-1-ov-file#readme ). A good summary of what apache 2.0 license allows us to do with and not is available over at snyk: https://snyk.io/learn/apache-license/
Under the Apache license, users are permitted to modify, distribute, and sublicense the original open source code. Commercial use, warranties, and patent claims are also allowed with the Apache license.
....
When using the Apache license, developers must include the original copyright notice, a copy of the license text itself, and in some cases, a copy of the notice file with attribution notes and a disclosure of any significant changes made to the original code.
....
With that said, ofc it would be nice to hear from the original author of keynstroke and his desires beside license thoughts :)
Vertygo
force-pushed
the
mouse-click-effect
branch
from
584d104 to
dd383c8
Compare
|
Design wise, something like this would be great. But let me not interfere with this to much! Your PR looks already very nice without my comment. Thanks, have been wanting this! |
|
@nicknijenhuis a nice effect, I think this could be achieved with a combination of timer(s) and GDI+. If there is enough interest for it, I could spend some time implementing it at later point in separate PR as I would like to avoid scope creeping this PR otherwise it won't be finished soon. |
Vertygo
force-pushed
the
mouse-click-effect
branch
from
ed735b4 to
57b1be0
Compare
Added a mouse click effect feature for screen recording. This will enable people to see when click is performed in video.
This PR covers the following feature requests
#6785
#5570
#4097
#6799
Example of feature in action
rider64_ougsyFhm9S.mp4
Review comments todo: