fix(minVersionBump): swapped minor/major

Sergey-Volkonskiy · Jul 30, 2020 · 56fd4ee · 56fd4ee
1 parent 35c1992
commit 56fd4ee
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@uniswap/token-lists",
   "author": "Moody Salem",
-  "version": "1.0.0-beta.10",
+  "version": "1.0.0-beta.11",
   "license": "MIT",
   "main": "dist/index.js",
   "typings": "dist/index.d.ts",

diff --git a/src/minVersionBump.ts b/src/minVersionBump.ts
@@ -12,8 +12,8 @@ export function minVersionBump(
   updatedList: TokenInfo[]
 ): VersionUpgrade {
   const diff = diffTokenLists(baseList, updatedList);
-  if (diff.added.length > 0) return VersionUpgrade.MAJOR;
-  if (diff.removed.length > 0) return VersionUpgrade.MINOR;
+  if (diff.removed.length > 0) return VersionUpgrade.MAJOR;
+  if (diff.added.length > 0) return VersionUpgrade.MINOR;
   if (Object.keys(diff.changed).length > 0) return VersionUpgrade.PATCH;
   return VersionUpgrade.NONE;
 }
diff --git a/test/minVersionBump.test.ts b/test/minVersionBump.test.ts
@@ -40,11 +40,11 @@ describe('#minVersionBump', () => {
       VersionUpgrade.PATCH
     );
   });
-  it('minor for remove only', () => {
-    expect(minVersionBump([tokenA], [])).toBe(VersionUpgrade.MINOR);
+  it('major for remove', () => {
+    expect(minVersionBump([tokenA], [])).toBe(VersionUpgrade.MAJOR);
   });
-  it('major for add', () => {
-    expect(minVersionBump([], [tokenA])).toBe(VersionUpgrade.MAJOR);
+  it('minor for add', () => {
+    expect(minVersionBump([], [tokenA])).toBe(VersionUpgrade.MINOR);
   });
   it('major for add/remove', () => {
     expect(minVersionBump([tokenB], [tokenA])).toBe(VersionUpgrade.MAJOR);