Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ac2] LOD-level override introduces visual artifacts #1

Open
illnyang opened this issue Aug 25, 2022 · 5 comments
Open

[ac2] LOD-level override introduces visual artifacts #1

illnyang opened this issue Aug 25, 2022 · 5 comments

Comments

@illnyang
Copy link

EaglePatch must do some filtering before forcing the LOD-level, this is already done for character models, but there are other things that appear glitchy.

Perhaps you could do retaddr checking?

Also, it would be nice if you added those leaked debug binaries you're using for people who want to reverse the game on their own and help with the project.

@Sergeanur
Copy link
Owner

I need more specifics about what other things appear glitchy, reproduction steps, etc.

I don't have any leaked debug binaries. The function names I took from Brotherhood on Mac, if you mean that.

@illnyang
Copy link
Author

I need more specifics about what other things appear glitchy, reproduction steps, etc.

I noticed the following when using that old LOD CE-based patcher on moddb, which I assume works the same:

During the game's prologue in Abstergo building (very first room where Lucy nags you), security camera's blinking red light orbs were way too big, going well outside camera model. Without LOD-level override, they are in their correct spot.

And yeah, I meant Brotherhood on Mac symbols. I forgot it wasn't a really leak. I wonder if you could use Diaphora to match the symbols between the binaries. Either way, I would love to contribute if time allows it. Can I contact you somewhere for a less issue-specific discussion?

@Sergeanur
Copy link
Owner

You can join my discord server, the link is on top of readme.md.

@JOHN30011887
Copy link

That camera red light bug at the very start of the game has always been there, they show as a red dot from far away but when walking closer to them they blow up bigger into a crescent moon sort of shape, even a quick youtube search of walkthrough i could see it

@illnyang illnyang changed the title [ac2] 2d shadows under character models are gone because of LOD-level override [ac2] LOD-level override introduces visual artifacts Aug 30, 2022
@illnyang
Copy link
Author

illnyang commented Aug 30, 2022

These buildings are placeholders that are used when given lod-level model is missing, I presume. There must be a way to tell which LOD-levels are available for a given model.

lod0placeholders

lod0placeholders2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants