Fixes from gometalinter

Senetas · Nov 2, 2018 · 9a40969 · 9a40969
1 parent e3cb1a1
commit 9a40969
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 14 deletions.
diff --git a/crypto/opts_test.go b/crypto/opts_test.go
@@ -61,20 +61,10 @@ func TestPassPhrase(t *testing.T) {
 		}
 
 		passphrase2, err := test.opts.GetPassphrase(test.passReader)
-		if assert.NoError(err) {
+		if !assert.NoError(err) {
 			continue
 		}
 
-		if !assert.Equal(test.passphrase, passphrase2) {
-			continue
-		}
+		assert.Equal(test.passphrase, passphrase2)
 	}
 }
-
-func TestStdinPassReader(t *testing.T) {
-	assert := assert.New(t)
-	passReader := crypto.StdinPassReader
-	assert.NotNil(passReader)
-
-	go passReader()
-}
diff --git a/distribution/distribution_test.go b/distribution/distribution_test.go
@@ -196,7 +196,10 @@ func blobTest(
 	}
 
 	if !equal {
-		showContents(t, filename, deconvpath)
+		err = showContents(t, filename, deconvpath)
+		if err != nil {
+			t.Error(err)
+		}
 		return
 	}
 

diff --git a/registry/httpclient/httpclient_test.go b/registry/httpclient/httpclient_test.go
@@ -31,7 +31,7 @@ func TestHTTPClient(t *testing.T) {
 
 	server := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
 		assert.Equal(req.URL.String(), "/")
-		rw.Write([]byte(`OK`))
+		_, _ = rw.Write([]byte(`OK`))
 	}))
 	defer server.Close()