Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for placement node that matches uri before creating one #55

Merged
merged 9 commits into from
Jul 19, 2024
Merged

check for placement node that matches uri before creating one #55

merged 9 commits into from
Jul 19, 2024

Conversation

rickwalder
Copy link
Contributor

prevents error "Duplicate Artifact" from clarity when updating a placement without clearing first

@smallsco
Copy link
Contributor

Hi @rickwalder ,

This PR is causing the unit tests to fail. Could you please take a look, and update the tests if required to work with this change?

Thanks for tracking this one down, I've run into this issue with a few customers when working on their workflow tests. Assuming there's no BC breaks I'd like to get it into the next release (which should be soon as there's a few PRs queued up now).

@smallsco smallsco changed the base branch from master to fix_coveralls_python_36 June 24, 2024 18:54
@smallsco smallsco deleted the branch SemaphoreSolutions:release_v1.6.0 June 25, 2024 15:20
@smallsco smallsco closed this Jun 25, 2024
@smallsco smallsco reopened this Jun 25, 2024
@smallsco smallsco changed the base branch from fix_coveralls_python_36 to master June 25, 2024 15:23
@smallsco
Copy link
Contributor

Hi @rickwalder ,

Can you please rebase this PR on the latest master branch? I'm trying to fix the test failures caused by coveralls and I'm hoping that my recent commit did it. (If not, then I'll disable it entirely and get you to rebase again).

@smallsco smallsco changed the base branch from master to release_v1.6.0 July 19, 2024 17:47
@smallsco smallsco merged commit 1c88ace into SemaphoreSolutions:release_v1.6.0 Jul 19, 2024
10 checks passed
@smallsco smallsco mentioned this pull request Jul 19, 2024
Merged
smallsco added a commit that referenced this pull request Jul 19, 2024
@smallsco
Release v1.6.0 (#62)
b626228 
* Updated version.py and changelog for 1.6.0 release

* Declare support for Python 3.12 in setup.py (#60)

* Fix EPP log message duplication and missing log entries in Clarity 6+ when combining Python automations with LLTK/LITKs (#51)

* Fix EPP log message duplication and missing log entries in Clarity 6+ when combining Python automations with LLTK/LITKs

* Fix current_minor_version failure on Python 2

* StepRunner: ignore archived reagent kits when adding default reagents to a step (#53)

* Fix EPP log message duplication and missing log entries in Clarity 6+ when combining Python automations with LLTK/LITKs

* Fix current_minor_version failure on Python 2

* StepRunner: ignore archived reagent kits when adding default reagents to a step

* check for placement node that matches uri before creating one (#55)

* check for placement node that matches uri before creating one

* add missing quotes, fix for py2

* remove f

* Fix coveralls on Python 3.6 (#52)

* Enable automated unit testing with Python 3.12 (#56)

* Fix coveralls on Python 3.6

* Enable automated unit testing with Python 3.12

* Only trigger a production PyPi build on tags using semantic versioning (#57)

* Use latest versions of GitHub workflow actions, build with Python 3.12 (#58)

* Enable automated unit testing for Python 3.5 (#59)

* Fix coveralls parallel builds (#61)

---------

Co-authored-by: Scott Small <scott.small@semaphoresolutions.ca>

---------

Co-authored-by: Joe Rickwalder <jrickwalder@billiontoone.com>
@smallsco
Copy link
Contributor

Thanks for your contribution @rickwalder! This has been incorporated into the v1.6.0 release, which was just published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickwalder @smallsco