Fix EPP log message duplication and missing log entries in Clarity 6+ when combining Python automations with LLTK/LITKs #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallsco
force-pushed
the
fix_epp_log_duplication
branch
from
1dae8f2 to
41ea1c8
Compare
… when combining Python automations with LLTK/LITKs
smallsco
force-pushed
the
fix_epp_log_duplication
branch
from
41ea1c8 to
cc1e230
Compare
Merged
smallsco
added a commit
that referenced
this pull request
Jul 19, 2024
* Updated version.py and changelog for 1.6.0 release * Declare support for Python 3.12 in setup.py (#60) * Fix EPP log message duplication and missing log entries in Clarity 6+ when combining Python automations with LLTK/LITKs (#51) * Fix EPP log message duplication and missing log entries in Clarity 6+ when combining Python automations with LLTK/LITKs * Fix current_minor_version failure on Python 2 * StepRunner: ignore archived reagent kits when adding default reagents to a step (#53) * Fix EPP log message duplication and missing log entries in Clarity 6+ when combining Python automations with LLTK/LITKs * Fix current_minor_version failure on Python 2 * StepRunner: ignore archived reagent kits when adding default reagents to a step * check for placement node that matches uri before creating one (#55) * check for placement node that matches uri before creating one * add missing quotes, fix for py2 * remove f * Fix coveralls on Python 3.6 (#52) * Enable automated unit testing with Python 3.12 (#56) * Fix coveralls on Python 3.6 * Enable automated unit testing with Python 3.12 * Only trigger a production PyPi build on tags using semantic versioning (#57) * Use latest versions of GitHub workflow actions, build with Python 3.12 (#58) * Enable automated unit testing for Python 3.5 (#59) * Fix coveralls parallel builds (#61) --------- Co-authored-by: Scott Small <scott.small@semaphoresolutions.ca> --------- Co-authored-by: Joe Rickwalder <jrickwalder@billiontoone.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Clarity LIMS 6.0 and above, when writing an automation for a step that:
then in some cases, log messages can either become duplicated - resulting in extra large log files - or missing. This behaviour seems to depend on the order in which the scripts are executed as part of the automation.
An example that exhibits such behaviour is as follows:
The root cause of this issue is due to the fact that in Clarity 6, the log file name for LLTK/LITKs was changed to include
LogFileas part of the file name, and not just the ResultFile LimsID. Thus, in order to squash this bug, the s4-clarity library needs to be updated to:As part of this, I have added a couple of new properties to the
s4.clarity.LIMSobject:s4.clarity.LIMS.versions- returns a list of all API versions supported by the active version of Clarity LIMSs4.clarity.LIMS.current_minor_version- returns the minor version ("revision") of the active Clarity LIMS API version.