Skip to content

Commit

Permalink
Try various ways to fix the action failing and logs being lost
Browse files Browse the repository at this point in the history
Capture and upload logs, logspam less, increase the timeout on the step
and not just the job.
  • Loading branch information
tbodt committed Dec 21, 2020
1 parent 4256e37 commit 7857c5f
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
9 changes: 8 additions & 1 deletion .github/workflows/upload-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ jobs:
./download-repos.py
- name: Fastlane
run: bundle exec fastlane upload_build
timeout-minutes: 720
run: script fastlane.log bundle exec fastlane upload_build
env:
APP_STORE_CONNECT_API_KEY_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_ISSUER_ID }}
APP_STORE_CONNECT_API_KEY_KEY_ID: ${{ secrets.APP_STORE_CONNECT_KEY_ID }}
Expand All @@ -41,3 +42,9 @@ jobs:
iSH.ipa
iSH.app.dSYM.zip
iSH-appstore.app.dSYM.zip
- uses: actions/upload-artifact@v2
if: ${{ always() }}
with:
name: Fastlane Logs
path: fastlane.log
1 change: 1 addition & 0 deletions fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ lane :upload_build do
upload_to_testflight(
ipa: "iSH-appstore.ipa",
changelog: testflight_changelog,
wait_for_processing_interval: 300, # the processing is expected to take a total of 5 hours, so don't logspam too much
)

# uploading a build takes about 5 hours, so merge master back in if there have been any commits during that
Expand Down

0 comments on commit 7857c5f

Please sign in to comment.