Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow uninstall of apps with underscore #3129

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Allow uninstall of apps with underscore #3129

merged 1 commit into from
Feb 22, 2019

Conversation

janpio
Copy link
Contributor

@janpio janpio commented Feb 14, 2019

Currently it is not possible to uninstall apps that have a _ in their name. E.g. uninstall scoop_ruby uninstalls scoop.

Based on #3128 (comment)

closes #3128

@janpio janpio mentioned this pull request Feb 14, 2019
Closed
@Ash258
Copy link
Contributor

Ash258 commented Feb 14, 2019

Duplicate of #2930

If you add test cases, this would be merged i think, since #2930 is stale for few weeks

@janpio
Copy link
Contributor Author

janpio commented Feb 14, 2019

Can do.

@r15ch13 r15ch13 merged commit e72eb65 into ScoopInstaller:master Feb 22, 2019
@janpio janpio deleted the patch-1 branch February 22, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@janpio @Ash258 @r15ch13