Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip installation if the version is already installed #27

Merged
merged 8 commits into from
Feb 14, 2019
Merged

skip installation if the version is already installed #27

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9e5b27f
remove ansi codes from provided version string
kentac55 Feb 11, 2019
c8079bf
add check func whether the specify version is already installed or not
kentac55 Feb 11, 2019
80c5c8b
Revert "remove ansi codes from provided version string"
kentac55 Feb 12, 2019
83a52e0
apply code review(rename check function)
kentac55 Feb 12, 2019
07f7457
run esy fmt
kentac55 Feb 12, 2019
2103111
move short path to the top of the switch case
kentac55 Feb 12, 2019
5700c46
use Result.fold instead of switch case
kentac55 Feb 12, 2019
7f92279
use Array.exists instead of List.exists
kentac55 Feb 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
remove ansi codes from provided version string
  • Loading branch information
@kentac55
kentac55 committed Feb 11, 2019
commit 9e5b27f942e8be94c1bffda13a254f46cbf3dece
3 changes: 2 additions & 1 deletion library/Versions.re
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ let format = version => {
| exception _ => version
};

version;
let ansiCharRegex = Str.regexp({|\\027\[[0-9]+m|});
Str.global_replace(ansiCharRegex, "", String.escaped(version));
};

let endsWith = (~suffix, str) => {
Expand Down