[deep link] Ignore invalid aasa paths (path is null or empty, but has…

… a queryParams) (flutter#8339) * ignore invalid aasa path * Update deep_links_services.dart * isNullOrEmpty
Sarsilmaz02 · Sep 27, 2024 · b29a37e · b29a37e
1 parent fefdb57
commit b29a37e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_services.dart b/packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_services.dart
@@ -8,6 +8,7 @@ import 'dart:convert';
 import 'package:flutter/foundation.dart';
 import 'package:http/http.dart';
 
+import '../../shared/primitives/utils.dart';
 import 'deep_links_model.dart';
 
 const _apiKey = 'AIzaSyCf_2E9N2AUZR-YSnZTQ72YbCNhKIskIsw';
@@ -212,6 +213,10 @@ class DeepLinksService {
                   ?.cast<Map<String, Object?>>();
               if (aasaPaths != null) {
                 for (final aasaPath in aasaPaths) {
+                  final path = aasaPath[_pathKey] as String?;
+                  if (path.isNullOrEmpty) {
+                    continue;
+                  }
                   final rawQueryParams = (aasaPath[_queryParamsKey] as List?)
                       ?.cast<Map<String, Object?>>();
                   final queryParams = <String, String>{
@@ -220,7 +225,7 @@ class DeepLinksService {
                   };
                   paths.putIfAbsent(domainName, () => <Path>[]).add(
                         Path(
-                          path: aasaPath[_pathKey] as String,
+                          path: path!,
                           queryParams: queryParams,
                           isExcluded:
                               aasaPath[_isExcludedKey] as bool? ?? false,

diff --git a/packages/devtools_app/test/test_infra/test_data/deep_link/fake_responses.dart b/packages/devtools_app/test/test_infra/test_data/deep_link/fake_responses.dart
@@ -167,6 +167,16 @@ const iosValidationResponseWithNoError = '''
               ],
               "isCaseSensitive": true,
               "isPercentEncoded": true
+            },
+            {
+              "queryParams": [
+                {
+                  "key": "dplnk",
+                  "value": "?*"
+                }
+              ],
+              "isCaseSensitive": true,
+              "isPercentEncoded": true
             }
           ]
         }