Merge branch 'master' into 2.37.3

Sarsilmaz02 · Sep 27, 2024 · 79f8ea9 · 79f8ea9
2 parents fc23e71 + 65eb5f5
commit 79f8ea9
Show file tree

Hide file tree

Showing 439 changed files with 438,874 additions and 5,610 deletions.
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -29,7 +29,7 @@ jobs:
       - name: git clone
         uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac
       - name: Load Cached Flutter SDK
-        uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84
+        uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9
         with:
           path: |
             ./tool/flutter-sdk
@@ -52,7 +52,7 @@ jobs:
         with:
           ref: "${{ github.event.pull_request.head.sha }}"
       - name: Load Cached Flutter SDK
-        uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84
+        uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9
         with:
           path: |
             ./tool/flutter-sdk
@@ -65,14 +65,14 @@ jobs:
           wget -qO- https://dcm.dev/pgp-key.public | sudo gpg --dearmor -o /usr/share/keyrings/dcm.gpg
           echo 'deb [signed-by=/usr/share/keyrings/dcm.gpg arch=amd64] https://dcm.dev/debian stable main' | sudo tee /etc/apt/sources.list.d/dart_stable.list
           sudo apt-get update
-          sudo apt-get install dcm=1.18.1-1 # To avoid errors add `-1` (build number) to the version
+          sudo apt-get install dcm=1.22.0-1 # To avoid errors add `-1` (build number) to the version
           sudo chmod +x /usr/bin/dcm
           echo "$(dcm --version)"
       - name: Setup Dart SDK
-        uses: dart-lang/setup-dart@b64355ae6ca0b5d484f0106a033dd1388965d06d
+        uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672
       - name: Run DCM on root
         run: |
-          dcm analyze packages/devtools_app packages/devtools_shared packages/devtools_test
+          dcm analyze packages/devtools_app packages/devtools_app_shared packages/devtools_extensions packages/devtools_shared packages/devtools_test
 
   test-packages:
     name: ${{ matrix.package }} test
@@ -89,7 +89,7 @@ jobs:
       - name: git clone
         uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac
       - name: Load Cached Flutter SDK
-        uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84
+        uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9
         with:
           path: |
             ./tool/flutter-sdk
@@ -115,7 +115,7 @@ jobs:
       - name: git clone
         uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac
       - name: Load Cached Flutter SDK
-        uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84
+        uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9
         with:
           path: |
             ./tool/flutter-sdk
@@ -142,7 +142,7 @@ jobs:
       - name: git clone
         uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac
       - name: Load Cached Flutter SDK
-        uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84
+        uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9
         with:
           path: |
             ./tool/flutter-sdk
@@ -155,7 +155,7 @@ jobs:
         run: ./tool/ci/bots.sh
 
       - name: Upload Golden Failure Artifacts
-        uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32
+        uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029
         if: failure()
         with:
           name: golden_image_failures.${{ matrix.bot }}
@@ -212,7 +212,7 @@ jobs:
       - name: git clone
         uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac
       - name: Load Cached Flutter SDK
-        uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84
+        uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9
         with:
           path: |
             ./tool/flutter-sdk
@@ -226,7 +226,7 @@ jobs:
         run: ./tool/ci/bots.sh
 
       - name: Upload Golden Failure Artifacts
-        uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32
+        uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029
         if: failure()
         with:
           name: golden_image_failures.${{ matrix.bot }}
@@ -245,7 +245,7 @@ jobs:
       - name: git clone
         uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac
       - name: Load Cached Flutter SDK
-        uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84
+        uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9
         with:
           path: |
             ./tool/flutter-sdk
@@ -266,7 +266,7 @@ jobs:
       - name: git clone
         uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac
       - name: Load Cached Flutter SDK
-        uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84
+        uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9
         with:
           path: |
             ./tool/flutter-sdk
@@ -284,7 +284,7 @@ jobs:
       - name: git clone
         uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac
       - name: Load Cached Flutter SDK
-        uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84
+        uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9
         with:
           path: |
             ./tool/flutter-sdk

diff --git a/.github/workflows/daily-dev-bump.yaml b/.github/workflows/daily-dev-bump.yaml
@@ -41,9 +41,9 @@ jobs:
         with:
           ref: master
 
-      - uses: dart-lang/setup-dart@b64355ae6ca0b5d484f0106a033dd1388965d06d
+      - uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672
       - name: Load Cached Flutter SDK
-        uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84
+        uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9
         with:
           path: |
             ./tool/flutter-sdk

diff --git a/.github/workflows/flutter-candidate-update.yaml b/.github/workflows/flutter-candidate-update.yaml
@@ -25,7 +25,7 @@ jobs:
         with:
           ref: master
 
-      - uses: dart-lang/setup-dart@b64355ae6ca0b5d484f0106a033dd1388965d06d
+      - uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672
 
       - name: setup git config
         run: |

diff --git a/.github/workflows/flutter-prep.yaml b/.github/workflows/flutter-prep.yaml
@@ -39,7 +39,7 @@ jobs:
 
       - name: Load Cached Flutter SDK
         id: cache-flutter
-        uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84
+        uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9
         with:
           path: |
             ./tool/flutter-sdk

diff --git a/.github/workflows/scorecards-analysis.yml b/.github/workflows/scorecards-analysis.yml
@@ -43,7 +43,7 @@ jobs:
 
       # Upload the results as artifacts (optional).
       - name: "Upload artifact"
-        uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32
+        uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029
         with:
           name: SARIF file
           path: results.sarif

diff --git a/CODEOWNERS b/CODEOWNERS
@@ -1,22 +1,19 @@
 *                   @flutter/devtools-reviewers
 
 # Inspector Files
-inspector/          @CoderDake
+inspector/          @elliette
 
 # Network Files
-network/            @kenzieschmoll @bkonyi
+network/            @bkonyi @kenzieschmoll
 
 # Performance Files
 performance/        @kenzieschmoll
 
 # CPU Profiler files
-profiler/           @kenzieschmoll
+profiler/           @kenzieschmoll @bkonyi
 
 # Memory files
-memory/             @bkonyi @polina-c
-
-# Memory leak tracking files
-memory/panes/leaks  @CoderDake @polina-c
+memory/             @bkonyi @kenzieschmoll
 
 # Debugger files
 debugger/           @elliette
@@ -25,10 +22,15 @@ debugger/           @elliette
 vm_developer/       @bkonyi
 
 # Tooling files
-/tool/              @CoderDake
+/tool/              @kenzieschmoll
 
+# DevTools extensions and related files
+src/extensions/
 packages/devtools_extensions/    @kenzieschmoll
+packages/devtools_app_shared/    @kenzieschmoll
 
+# package:devtools_shared code, which is used across DevTools and the Dart SDK
+packages/devtools_shared/        @kenzieschmoll @bkonyi
 
 # Version bump files.
 # No owners to prevent version update spam

diff --git a/TRIAGE.md b/TRIAGE.md
@@ -2,27 +2,48 @@
 
 ## The Process
 
-If you are the devtools triage rotation on-call, you are expected to triage issues that appeared/updated during the week (it is ok to triage all of them at the end of the week).
+DevTools issues are triaged as time allows throughout the week, and during a dedicated triage meeting that occurs weekly.
+During the triage meeting, new and existing issues are categorized, prioritized, and / or commented on to provide updates
+or gather clarification.
 
-You are also expected to monitor the DevTools discord [channel](https://discord.com/channels/608014603317936148/958862085297672282) for user questions / concerns.
+The DevTools discord [channel](https://discord.com/channels/608014603317936148/958862085297672282) is also scrubbed for
+any recent user questions / concerns that require a response.
 
 ## DevTools Issues
 
-Queue: https://github.com/flutter/devtools/issues?q=is%3Aopen+is%3Aissue+-label%3AP0%2CP1%2CP2%2CP3%2CP4%2CP5%2CP6 
+Queue: https://github.com/flutter/devtools/issues?q=is%3Aopen+is%3Aissue+-label%3AP0%2CP1%2CP2%2CP3
 
-For each new issue that comes in, perform all of these tasks that apply:
+For each issue, perform all of these tasks that apply:
 
 ### Label/project the issue:
 * Add labels for its proper category or categories ( “Inspector page”, “debugger page”, “bug”, etc.)
 * Add label “waiting for customer response” if you requested more details from reporter
 * Add label “fix it friday” if the issue should be fixed and looks easy to fix
-* Add to project [go/dart-devtools-ux-issues](https://github.com/orgs/flutter/projects/54/settings) if the issue is cross-screen issue
+* Add label "good first issue" if the issue looks like an easy starter bug for a new contributor
 
 ### Prioritize the issue. 
 
 Follow the prioritization rubric [here](https://github.com/flutter/flutter/blob/master/docs/contributing/issue_hygiene/README.md#priorities).
 
-Tag the area owner in a comment if the issue requires specific expertise. Assign to an owner if the issue is a work in process or if the issue needs immediate / almost-immediate attention (P0, P1).
+If the issue requires specific expertise, tag a product area owner (see below) in a comment and ask them to take a look. 
+If the issue is actively being worked on or if it needs immediate / almost-immediate attention (P0, P1), assign the issue
+to a product area owner.
+
+Here are some suggested owners by product area:
+* **Flutter Inspector**: @elliette
+* **Performance**: @kenzieschmoll
+* **CPU Profiler**: @kenzieschmoll or @bkonyi
+* **Memory**: @kenzieschmoll or @bkonyi
+* **Network**: @elliette or @bkonyi
+* **Logging**: @elliette or @bkonyi
+* **VM Tools**: @bkonyi
+* **Debugger**: @elliette
+* **DevTools extensions**: @kenzieschmoll
+* **Tooling integrations with VS Code**: @DanTup
+* **Tooling integrations with IntelliJ or Android Studio**: @helin24 or @jwren
+
+For anything else that requires immediate attention but does not fit into one of
+the above areas, please tag @kenzieschmoll or @elliette.
 
 ## Related Flutter Issues
 

diff --git a/flutter-candidate.txt b/flutter-candidate.txt
@@ -1 +1 @@
-3.23.0-13.0.pre
+8925e1ffdfe880b06a8bc5877f017083d6652f5b
diff --git a/packages/.vscode/launch.json b/packages/.vscode/launch.json
@@ -23,7 +23,7 @@
             "program": "devtools_app/lib/main.dart",
             "args": [
                 "--dart-define",
-                "memory_offline_experiment=true",
+                "memory_disconnect_experience=true",
                 "--dart-define",
                 "enable_experiments=true",
             ],
@@ -101,6 +101,13 @@
             "type": "dart",
             "program": "devtools_app/test/test_infra/scenes/standalone_ui/vs_code.stager_app.g.dart",
         },
+        {
+            "name": "standalone_ui/editor_sidebar",
+            "request": "launch",
+            "type": "dart",
+            "program": "devtools_app/test/test_infra/scenes/standalone_ui/editor_sidebar.stager_app.g.dart",
+            "preLaunchTask": "Start DTD on Port 8500",
+        },
         {
             "name": "devtools_extensions: foo + sim",
             "request": "launch",
@@ -145,5 +152,5 @@
                 "--dart-define=use_simulated_environment=true"
             ],
         },
-    ]
+    ],
 }
diff --git a/packages/.vscode/tasks.json b/packages/.vscode/tasks.json
@@ -0,0 +1,41 @@
+{
+	"version": "2.0.0",
+	"tasks": [
+		{
+			"label": "Start DTD on Port 8500",
+			"detail": "Starts a DTD instance running on port 8500",
+			"type": "shell",
+			"command": "${workspaceFolder}/../tool/flutter-sdk/bin/cache/dart-sdk/bin/dart",
+			"args": [
+				"tooling-daemon",
+				"--disable-service-auth-codes",
+				"--port=8500",
+			],
+			// Don't bring the asks list to the front as this is usually invoked as a background
+			// task for the standalone_ui/editor_sidebar launch config.
+			"presentation": {
+				"reveal": "never"
+			},
+			// We need to run this as a background task, otherwise VS Code would wait for it to
+			// complete/terminate before running the debug session.
+			"isBackground": true,
+			"group": "none",
+			// Background tasks need to indicate to VS Code when they are "working" and when they are complete
+			// and the debug session can start. This is done via a problemMatcher even if you don't want to match
+			// problems so we need to set some parameters that will consider us "ready" when the DTD banner
+			// is printed to stdout.
+			"problemMatcher": [
+				{
+					"background": {
+						"activeOnStart": true,
+						"beginsPattern": "NOT-USED-XXXXXXXXXX", // We never need to go back into working state.
+						"endsPattern": "The Dart Tooling Daemon is listening on" // Finished working.
+					},
+					"pattern": {
+						"regexp": "NOT-USED-XXXXXXXXXX", // We never want to find any problems in the output.
+					}
+				}
+			]
+		}
+	]
+}
diff --git a/packages/devtools_app/benchmark/README.md b/packages/devtools_app/benchmark/README.md
@@ -81,3 +81,30 @@ There are two ways to calculate the delta between two benchmark test runs:
         ```sh
         dart run benchmark/scripts/run_benchmarks.dart --baseline=/Users/me/baseline_file.json``
         ```
+
+# Compare dart2wasm performance to dart2js
+
+Here are step-by-step instructions for comparing the performance
+of `dart2wasm` with `dart2s` for DevTools benchmark tests.
+
+1. From the `devtools_app` directory, run
+    ```sh
+    dart run benchmark/scripts/dart2wasm_performance_diff.dart
+    ```
+
+    Optional flags (to see the full usage description, run the above command with `-h`):
+    * `--average-of`: specifies the number of times to run each benchmark.
+    The returned results will be the average of all the benchmark runs when
+    this value is greater than 1. If left unspecified, each benchmark will
+    only be run once.
+    * `--save-to-file`: the absolute file path to the location where you want the
+    benchmark comparison to be saved as a CSV file. This will default to the
+    `Downloads/` directory if left unspecified.
+    * `--baseline`: the absolute file path to the baseline benchmark data (dart2js)
+    to use for this performance diff. Only use this option when you do not
+    want to run a new benchmark for the dart2js results.
+    * `--test`: the absolute file path to the test benchmark data (dart2wasm)
+    to use for this performance diff. Only use this option when you do not
+    want to run a new benchmark for the dart2wasm results.
+
+2. Open the CSV file in a spreadsheet application (Google Sheets, Excel, etc.) for viewing.
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		3.23.0-13.0.pre
		8925e1ffdfe880b06a8bc5877f017083d6652f5b