Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error on kubernetes pages and kubernetes endpoint page. #96

Merged
merged 10 commits into from
Nov 20, 2018
Merged

Show error on kubernetes pages and kubernetes endpoint page. #96

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
62ca003
Wire in internal errors into api error wrapper
KlapTrap Nov 15, 2018
c7d2091
Use common endpoint id routing variable for easier header errors
KlapTrap Nov 15, 2018
6aa5ea7
Ensure internal error status is string
richard-cox Nov 16, 2018
a2e588d
Add internal error for non-passthrough cf calls
richard-cox Nov 16, 2018
fb0ebf1
Ensure all status codes are strings
richard-cox Nov 16, 2018
6669870
Fix error where header error message doesn't show correctly
KlapTrap Nov 16, 2018
0e2ad0d
Clean up kubernetes entities when disconnecting k8s endpoint type
KlapTrap Nov 16, 2018
8f2aa39
Merge remote-tracking branch 'origin/v2-master' into kube-endpoint-er…
richard-cox Nov 19, 2018
e4c3c1a
Fix more `cfId` --> `endpointId`
richard-cox Nov 19, 2018
e514c58
Improve e2e tests
richard-cox Nov 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ensure all status codes are strings
  • Loading branch information
@richard-cox
richard-cox committed Nov 16, 2018
commit fb0ebf13fa37045aeff51e213ab473a39535856f
2 changes: 1 addition & 1 deletion src/frontend/app/store/effects/cloud-foundry.effects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export class CloudFoundryEffects {
new WrapperRequestActionFailed(error.message, apiAction, actionType, {
endpointIds: [action.cfGuid],
url: error.url || url,
eventCode: error.status || '500',
eventCode: error.status ? error.status + '' : '500',
message: 'Cloud Foundry Info request error',
error
})
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/app/store/effects/metrics.effects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export class MetricsEffect {
'fetch', {
endpointIds: [action.endpointGuid],
url: errObservable.url || fullUrl,
eventCode: errObservable.status || '500',
eventCode: errObservable.status ? errObservable.status + '' : '500',
message: 'Metric request error',
}
)
Expand Down