Fixing slider issues identified:

The linter identified that warnings was unused in hash-format.py The linter found that the skip_test function call was using 2 space indentation (not sure how I managed to do that). Warning was originally added as hash-format gave a warning on ALLOWED_HASH_FORMATS != default That was changed to instead test the different cases directly. option--config.py skips the test if the default algorithm is not MD5 as the hashes used are OS-specific, and supporting it in FIPS mode would be difficult. It's better to just skip this testcase in FIPS mode instead as this specific test is different in that regard to the other FIPS-enabled tests.
SCons · Nov 9, 2021 · 0ff5949 · 0ff5949
1 parent 699d6b0
commit 0ff5949
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/test/Configure/option--config.py b/test/Configure/option--config.py
@@ -46,7 +46,7 @@
 # as this test is somewhat complicated, skip it if the library doesn't support md5
 # as the default hashing algorithm.
 if get_current_hash_algorithm_used() != 'md5':
-  test.skip_test('Skipping test as could not continue without the hash algorithm set to md5!')
+    test.skip_test('Skipping test as could not continue without the hash algorithm set to md5!')
 
 SConstruct_path = test.workpath('SConstruct')
 

diff --git a/test/option/hash-format.py b/test/option/hash-format.py
@@ -27,7 +27,6 @@
 import hashlib
 import os
 import TestSCons
-import warnings
 from SCons.Util import ALLOWED_HASH_FORMATS, DEFAULT_HASH_FORMATS
 
 # Test passing the hash format by command-line.