Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: stabilize test #10532

Merged
merged 1 commit into from
Jan 16, 2025
Merged

chore: stabilize test #10532

merged 1 commit into from
Jan 16, 2025

Conversation

didip1000
Copy link
Contributor

The test would fail because the years in ui5-year-picker shift depending on the current year. This fix updates the test to use the first year in the picker, which is always at the first index.

Fixes: #10451

@didip1000 didip1000 requested a review from hinzzx January 13, 2025 12:09
@didip1000 didip1000 self-assigned this Jan 13, 2025
@nnaydenow
Copy link
Contributor

use chore or refactor for the PR title. This change is not related to the components and it doesn't need to appear inside changelog.

@didip1000 didip1000 changed the title fix(ui5-daterange-picker): stabilize test chore: stabilize test Jan 13, 2025
Copy link
Contributor

@hinzzx hinzzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is ensuring that a selection is made, so it looks good to me.

@didip1000 didip1000 marked this pull request as ready for review January 16, 2025 07:44
@didip1000 didip1000 merged commit ef037bd into main Jan 16, 2025
10 checks passed
@didip1000 didip1000 deleted the drp-failing-test branch January 16, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui5-daterange-picker test failure
4 participants