refactor: make InputSuggestions a normal dynamic import #10510
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a part of the component features rework which was made possible by the transition to TSX (since the templates themselves now bring the dependencies and the only responsibility of the features concept was dependency management, which is now obsolete for TSX-enabled components)
ComponentFeature
base class or features registryInputSuggestions.js
module as before (nothing changed in this regard) and this will act as a "preload" and will simply skip the dynamic import inenableSuggestions
later.InputSuggestions.js
, and still tries to setshowSuggestions = true
, there will no longer be a console warning, but it will work by dynamically importing the feature and using it.Inside
Input.ts
theSuggestions
property is now managed state, because we want it to be invalidating (when the dynamic import is ready, andthis.Suggestions
is set, theui5-input
must invalidate for the suggestions template to be rendered)Additionally, deleted some leftover commented test code: