-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-table): table row actions feature added #10460
Conversation
a40450c
to
f8b76e7
Compare
f8b76e7
to
e477bcc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Waiting for docs review and adjustments
packages/website/docs/_samples/main/Table/RowAction/RowAction.md
Outdated
Show resolved
Hide resolved
packages/website/docs/_samples/main/Table/RowActionNavigation/RowActionNavigation.md
Outdated
Show resolved
Hide resolved
First push after the last rebase
e477bcc
to
24ff60c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I talked with colleagues and they suggested to replace the "hidden" property with "invisible" I will push another change |
24ff60c
to
7175432
Compare
e3a497d
to
4c58e14
Compare
* feat(ui5-table): table row actions - rebase First push after the last rebase * feat(ui5-table): Table row actions * feat(ui5-table): table row actions feature added * feat(ui5-table): table row actions feature added --------- Co-authored-by: Felix Schubert <felix.schubert@sap.com> Co-authored-by: ilhan007 <ilhan.myumyun@sap.com>
TableRowActionBase
components such asui5-table-row-action
orui5-table-row-action-navigation
can be used. This allows consumers to add interactive elements to each row, providing users the ability to perform actions related with the row.row-action-count
property of theui5-table
component defines the width of the row action column. It is recommended to use a maximum value of3
, as exceeding this limit may take up too much space on smaller screens. If the number of row actions exceeds therow-action-count
, an overflow button will be displayed to allow access to the additional actions.hidden
property of row actions allows consumers to hide specific row actions while preserving their space. This can be useful for consistent alignment of row actions across different rows.