Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-table): table row actions feature added #10460

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Conversation

aborjinik
Copy link
Contributor

  • To enable row actions, the TableRowActionBase components such as ui5-table-row-action or ui5-table-row-action-navigation can be used. This allows consumers to add interactive elements to each row, providing users the ability to perform actions related with the row.
  • The row-action-count property of the ui5-table component defines the width of the row action column. It is recommended to use a maximum value of 3, as exceeding this limit may take up too much space on smaller screens. If the number of row actions exceeds the row-action-count, an overflow button will be displayed to allow access to the additional actions.
  • The hidden property of row actions allows consumers to hide specific row actions while preserving their space. This can be useful for consistent alignment of row actions across different rows.

@aborjinik aborjinik force-pushed the table-with-row-actions branch 4 times, most recently from a40450c to f8b76e7 Compare January 6, 2025 16:23
@aborjinik aborjinik changed the title Table with row actions feat(ui5-table): table row actions feature added Jan 6, 2025
@aborjinik aborjinik requested review from DonkeyCo and KvM2 January 7, 2025 07:25
packages/main/src/Table.ts Show resolved Hide resolved
packages/main/src/TableRow.ts Outdated Show resolved Hide resolved
packages/main/src/TableRowActionBase.ts Show resolved Hide resolved
packages/main/src/TableRow.ts Outdated Show resolved Hide resolved
packages/main/src/TableRowActionBase.ts Outdated Show resolved Hide resolved
packages/main/src/TableRowAction.ts Outdated Show resolved Hide resolved
packages/main/src/TableRowActionBase.ts Outdated Show resolved Hide resolved
packages/main/src/TableRowActionBase.hbs Outdated Show resolved Hide resolved
packages/main/src/TableRowActionNavigation.ts Outdated Show resolved Hide resolved
@aborjinik aborjinik force-pushed the table-with-row-actions branch from f8b76e7 to e477bcc Compare January 8, 2025 10:14
@aborjinik aborjinik requested a review from DonkeyCo January 8, 2025 10:14
packages/main/src/Table.ts Outdated Show resolved Hide resolved
packages/main/src/Table.ts Outdated Show resolved Hide resolved
packages/main/src/Table.ts Outdated Show resolved Hide resolved
packages/main/src/Table.ts Outdated Show resolved Hide resolved
Copy link
Member

@DonkeyCo DonkeyCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for docs review and adjustments

@aborjinik aborjinik force-pushed the table-with-row-actions branch from e477bcc to 24ff60c Compare January 8, 2025 19:54
@aborjinik aborjinik requested a review from KvM2 January 9, 2025 07:49
@aborjinik aborjinik requested a review from DonkeyCo January 9, 2025 07:49
Copy link
Member

@DonkeyCo DonkeyCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aborjinik
Copy link
Contributor Author

I talked with colleagues and they suggested to replace the "hidden" property with "invisible" I will push another change

@aborjinik aborjinik force-pushed the table-with-row-actions branch from 24ff60c to 7175432 Compare January 10, 2025 03:56
@aborjinik aborjinik force-pushed the table-with-row-actions branch from e3a497d to 4c58e14 Compare January 10, 2025 09:39
@aborjinik aborjinik merged commit dfe09ae into main Jan 10, 2025
10 checks passed
@aborjinik aborjinik deleted the table-with-row-actions branch January 10, 2025 10:04
ilhan007 added a commit that referenced this pull request Jan 13, 2025
* feat(ui5-table): table row actions - rebase

First push after the last rebase

* feat(ui5-table): Table row actions

* feat(ui5-table): table row actions feature added

* feat(ui5-table): table row actions feature added

---------

Co-authored-by: Felix Schubert <felix.schubert@sap.com>
Co-authored-by: ilhan007 <ilhan.myumyun@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants