Fix ambiguous method for AssertZeroizeOnDrop (#725)

RustCrypto · Jan 31, 2022 · ba4e7e7 · ba4e7e7
1 parent a37fa8d
commit ba4e7e7
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 2 deletions.
diff --git a/zeroize/src/lib.rs b/zeroize/src/lib.rs
@@ -271,7 +271,7 @@ pub mod __internal {
         fn zeroize_or_on_drop(self);
     }
 
-    impl<T: ZeroizeOnDrop> AssertZeroizeOnDrop for &mut T {
+    impl<T: ZeroizeOnDrop> AssertZeroizeOnDrop for &&mut T {
         fn zeroize_or_on_drop(self) {}
     }
 

diff --git a/zeroize/tests/zeroize_derive.rs b/zeroize/tests/zeroize_derive.rs
@@ -242,7 +242,7 @@ mod custom_derive_tests {
     }
 
     #[test]
-    fn derive_only_zeroize_on_drop() {
+    fn derive_inherit_zeroize_on_drop() {
         #[derive(ZeroizeOnDrop)]
         struct X([u8; 3]);
 
@@ -255,4 +255,34 @@ mod custom_derive_tests {
         }
         assert_eq!(&value.0 .0, &[0, 0, 0])
     }
+
+    #[test]
+    fn derive_inherit_from_both() {
+        #[derive(Zeroize, ZeroizeOnDrop)]
+        struct X([u8; 3]);
+
+        #[derive(ZeroizeOnDrop)]
+        struct Z(X);
+
+        let mut value = Z(X([1, 2, 3]));
+        unsafe {
+            std::ptr::drop_in_place(&mut value);
+        }
+        assert_eq!(&value.0 .0, &[0, 0, 0])
+    }
+
+    #[test]
+    fn derive_inherit_both() {
+        #[derive(Zeroize, ZeroizeOnDrop)]
+        struct X([u8; 3]);
+
+        #[derive(Zeroize, ZeroizeOnDrop)]
+        struct Z(X);
+
+        let mut value = Z(X([1, 2, 3]));
+        unsafe {
+            std::ptr::drop_in_place(&mut value);
+        }
+        assert_eq!(&value.0 .0, &[0, 0, 0])
+    }
 }