Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added M1 GPU support #522

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added M1 GPU support #522

wants to merge 1 commit into from

Conversation

erezak
Copy link

@erezak erezak commented Jul 6, 2023

newer versions of pytorch support the mps device.

@bruvduroiu
Copy link

Hi @erezak , wondering what version of M1 chip you're using and how you got around the OOM errors since MPS currently uses a lot of vRAM?

@rosho92
Copy link

rosho92 commented Nov 27, 2023

in testing, this merge request causes performance issues. Long videos result in errors where the face cannot be detected. Very possible a result of the concern raised by @bruvduroiu

However, when this works it results in a 10x performance improvement. A code revision to support M1 optimization while still within the operating limits of the system would be a huge improvement for mac silicon users as this architecture is increasingly growing in market share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants