Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.x: [Java 8] Add Observable operators + cleanup #6797

Merged
merged 1 commit into from
Dec 26, 2019
Merged

3.x: [Java 8] Add Observable operators + cleanup #6797

merged 1 commit into from
Dec 26, 2019

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Dec 26, 2019 •
edited
Loading

Add the following Java 8 operators to Observable:

  • fromOptional
  • fromCompletionStage
  • fromStream
  • firstStage
  • firstOrErrorStage
  • singeStage
  • singleOrErrorStage
  • lastStage
  • lastOrErrorStage
  • blockingStream
  • mapOptional
  • collect
  • concatMapStream / flatMapStream

In addition, some validators received reporting improvements (such as using at so the IDE can jump to the exact line of the issue). Consequently, all local variable misnaming of UnicastSubject up and UnicastProcessor us have been fixed as well.

Related #6776

@akarnokd akarnokd added Enhancement Cleanup 3.x Java 8 Issues and PRs related to Java 8 support labels Dec 26, 2019
@akarnokd akarnokd added this to the 3.0 milestone Dec 26, 2019
@akarnokd
Copy link
Member Author

akarnokd commented Dec 26, 2019 •
edited
Loading

Marbles:

image
image
image
image
image
image
image
image
image
image
image
image
image
image
image

@codecov
Copy link

codecov bot commented Dec 26, 2019

Codecov Report

Merging #6797 into 3.x will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6797      +/-   ##
============================================
- Coverage     98.24%   98.17%   -0.08%     
- Complexity     6283     6345      +62     
============================================
  Files           696      706      +10     
  Lines         45427    45846     +419     
  Branches       6233     6280      +47     
============================================
+ Hits          44632    45010     +378     
- Misses          278      309      +31     
- Partials        517      527      +10
Impacted Files Coverage Δ Complexity Δ
...a3/internal/jdk8/ObservableFirstStageObserver.java 100% <100%> (ø) 5 <5> (?)
...va3/internal/jdk8/ObservableLastStageObserver.java 100% <100%> (ø) 6 <6> (?)
...rxjava3/internal/jdk8/ObservableFlatMapStream.java 100% <100%> (ø) 5 <5> (?)
...ex/rxjava3/internal/jdk8/ObservableFromStream.java 100% <100%> (ø) 5 <5> (?)
...x/rxjava3/internal/jdk8/ObservableMapOptional.java 100% <100%> (ø) 2 <2> (?)
...ivex/rxjava3/internal/jdk8/FlowableFromStream.java 100% <100%> (+0.75%) 6 <0> (ø) ⬇️
...rxjava3/internal/jdk8/ObservableStageObserver.java 100% <100%> (ø) 9 <9> (?)
...ain/java/io/reactivex/rxjava3/core/Observable.java 100% <100%> (ø) 553 <17> (+16) ⬆️
...nal/jdk8/ObservableCollectWithCollectorSingle.java 100% <100%> (ø) 3 <3> (?)
...3/internal/jdk8/ObservableSingleStageObserver.java 100% <100%> (ø) 7 <7> (?)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 480889c...72b22cc. Read the comment docs.

@akarnokd akarnokd merged commit af17c6e into ReactiveX:3.x Dec 26, 2019
@akarnokd akarnokd deleted the ObservableJdk8Ops branch December 26, 2019 12:33
@akarnokd akarnokd mentioned this pull request Dec 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3.x Cleanup Enhancement Java 8 Issues and PRs related to Java 8 support
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@akarnokd