Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.x: [Java 8] Add blockingStream & flatMapStream to Flowable #6779

Merged
merged 1 commit into from
Dec 19, 2019
Merged

3.x: [Java 8] Add blockingStream & flatMapStream to Flowable #6779

merged 1 commit into from
Dec 19, 2019

Conversation

akarnokd
Copy link
Member

Add Java 8 interoperation methods to Flowable:

  • blockingStream - essentially blockingIterable with close support
  • concatMapStream - map and concatenate streams
  • flatMapStream - map and concatenate streams, inherently same as concatMapStream

Related #6776

Marbles:

image
image
image
image
image
image

@akarnokd akarnokd added Enhancement 3.x Java 8 Issues and PRs related to Java 8 support labels Dec 19, 2019
@akarnokd akarnokd added this to the 3.0 milestone Dec 19, 2019
@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #6779 into 3.x will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6779      +/-   ##
============================================
- Coverage     98.22%   98.21%   -0.01%     
- Complexity     6236     6248      +12     
============================================
  Files           688      689       +1     
  Lines         45041    45208     +167     
  Branches       6193     6220      +27     
============================================
+ Hits          44243    44403     +160     
- Misses          280      283       +3     
- Partials        518      522       +4
Impacted Files Coverage Δ Complexity Δ
...x/rxjava3/internal/jdk8/FlowableFlatMapStream.java 100% <100%> (ø) 5 <5> (?)
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <100%> (ø) 577 <7> (+7) ⬆️
...ivex/rxjava3/internal/jdk8/FlowableFromStream.java 99.24% <100%> (+0.01%) 6 <1> (+1) ⬆️
...l/operators/observable/ObservableFlatMapMaybe.java 83.8% <0%> (-7.75%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 89.68% <0%> (-4.77%) 2% <0%> (ø)
...nternal/operators/parallel/ParallelSortedJoin.java 92.7% <0%> (-2.92%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 93.22% <0%> (-2.09%) 2% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...nternal/operators/observable/ObservableWindow.java 98.18% <0%> (-1.82%) 3% <0%> (ø)
...a3/internal/operators/flowable/FlowableCreate.java 96.11% <0%> (-1.62%) 6% <0%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d41cc5...46eb3f4. Read the comment docs.

@akarnokd akarnokd merged commit a249f4f into ReactiveX:3.x Dec 19, 2019
@akarnokd akarnokd deleted the Jdk8Ops_1219 branch December 19, 2019 17:38
@akarnokd akarnokd mentioned this pull request Dec 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanniktech vanniktech vanniktech approved these changes

Assignees
No one assigned
Labels
3.x Enhancement Java 8 Issues and PRs related to Java 8 support
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@akarnokd @vanniktech