Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reference to BIND-* methods #4546

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Conversation

timo
Copy link
Contributor

@timo timo commented Dec 25, 2024

The text claimed that BIND-KEY is used to bind to an array element, but it is actually BIND-POS. Add a new sentence that still mentions BIND-KEY and what it is actually used for, since it's closely related.

The text claimed that BIND-KEY is used to bind to an array
element, but it is actually BIND-POS. Add a new sentence that
still mentions BIND-KEY and what it is actually used for, since
it's closely related.
@coke coke merged commit 8062c6d into main Dec 26, 2024
@coke coke deleted the correct-bind-key-bind-pos-mention branch December 26, 2024 00:56
@coke
Copy link
Collaborator

coke commented Dec 26, 2024

Thanks!

method (called L<C<BIND-KEY>|/routine/BIND-KEY>) is called on the
array. This method handles binding to array elements.
method (called L<C<BIND-POS>|/routine/BIND-POS>) is called on the
array. This method handles binding to array elements. There is also an
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tripped over this sentence a bit:

This method handles binding to array elements. There is also an equivalent method for binding to hash elements as well (called L<C|/routine/BIND-KEY>)

I can explain why if you want me to (just ask) but for now I'll simply suggest what would avoid me tripping up):

(Chandles binding to array elements. There is also a method for binding to I elements called L<C|/routine/BIND-KEY>.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh. The suggestion I wrote began with "C<BIND-POS> handles..." and ended with a proper RakuDoc link but of course GH gobbles such text. I'm tempted to delete my review given that it was just a very small thing but please just guess what I meant or feel free to ignore my comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants