Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TMDb languages for Movie Info Language #10482

Open
1 task done
infosebas opened this issue Sep 25, 2024 · 6 comments
Open
1 task done

Use TMDb languages for Movie Info Language #10482

infosebas opened this issue Sep 25, 2024 · 6 comments
Labels
Status: Help Wanted Help Wanted, no immediate plans for effort on this Status: Needs Triage New Issue needing triage Type: Feature Request Issue is a feature request.

Comments

@infosebas
Copy link

Is there an existing issue for this?

  • I have searched the existing open and closed issues

Is your feature request related to a problem? Please describe

We currently only have the choice to name movie folders in French (France) and we can only see the French (France) movie titles when doing a search.

Describe the solution you'd like

I would like to have the French (Canadian) language as a choice for Movie Info Language and UI Language.

Describe alternatives you've considered

I modified the language files and builded a personalized Radarr with French (Canadian) but I have to modify the files everytime there is an update and rebuild the executable win-x64. For the UI language, I did a copy of fr.json and renamed it fr_CA.json because translation for the UI in French (France) is good also for French (Canadian) in my opinion.

Anything else?

Here is some pictures of my personalized Radarr with Canadian movie titles and movies folder name.
Radarr-fr_CA-1
Radarr-fr_CA-2
Radarr-fr_CA-3
Radarr-fr_CA-4
Radarr-fr_CA-5
Radarr_Add_Languages
@infosebas infosebas added Status: Needs Triage New Issue needing triage Type: Feature Request Issue is a feature request. labels Sep 25, 2024
@bakerboy448
Copy link
Contributor

@bakerboy448 bakerboy448 added the Status: Help Wanted Help Wanted, no immediate plans for effort on this label Sep 25, 2024
@infosebas
Copy link
Author

TMDb does support fr-CA, you can see it on the website. They use the ISO 639-1 fr and the ISO 3166-1 CA

image

@mynameisbogdan
Copy link
Collaborator

Like we don't have support for both en-US and en-GB and so on, I'm pretty much against adding support for fr_CA since it would open a door to request every dialect under the sun.

And like the author said the fr.json translations are good for him, for Movie Info Language we should add support all the languages TMDb does without coupling them with our inner languages for translations system.

List of TMDb languages used at the moment for primary translations:

See More 
[
  "af-ZA",
  "ar-AE",
  "ar-BH",
  "ar-EG",
  "ar-IQ",
  "ar-JO",
  "ar-LY",
  "ar-MA",
  "ar-QA",
  "ar-SA",
  "ar-TD",
  "ar-YE",
  "be-BY",
  "bg-BG",
  "bn-BD",
  "br-FR",
  "ca-AD",
  "ca-ES",
  "ch-GU",
  "cs-CZ",
  "cy-GB",
  "da-DK",
  "de-AT",
  "de-CH",
  "de-DE",
  "el-CY",
  "el-GR",
  "en-AG",
  "en-AU",
  "en-BB",
  "en-BZ",
  "en-CA",
  "en-CM",
  "en-GB",
  "en-GG",
  "en-GH",
  "en-GI",
  "en-GY",
  "en-IE",
  "en-JM",
  "en-KE",
  "en-LC",
  "en-MW",
  "en-NZ",
  "en-PG",
  "en-TC",
  "en-US",
  "en-ZM",
  "en-ZW",
  "eo-EO",
  "es-AR",
  "es-CL",
  "es-DO",
  "es-EC",
  "es-ES",
  "es-GQ",
  "es-GT",
  "es-HN",
  "es-MX",
  "es-NI",
  "es-PA",
  "es-PE",
  "es-PY",
  "es-SV",
  "es-UY",
  "et-EE",
  "eu-ES",
  "fa-IR",
  "fi-FI",
  "fr-BF",
  "fr-CA",
  "fr-CD",
  "fr-CI",
  "fr-FR",
  "fr-GF",
  "fr-GP",
  "fr-MC",
  "fr-ML",
  "fr-MU",
  "fr-PF",
  "ga-IE",
  "gd-GB",
  "gl-ES",
  "he-IL",
  "hi-IN",
  "hr-HR",
  "hu-HU",
  "id-ID",
  "it-IT",
  "it-VA",
  "ja-JP",
  "ka-GE",
  "kk-KZ",
  "kn-IN",
  "ko-KR",
  "ku-TR",
  "ky-KG",
  "lt-LT",
  "lv-LV",
  "ml-IN",
  "mr-IN",
  "ms-MY",
  "ms-SG",
  "nb-NO",
  "nl-BE",
  "nl-NL",
  "no-NO",
  "pa-IN",
  "pl-PL",
  "pt-AO",
  "pt-BR",
  "pt-MZ",
  "pt-PT",
  "ro-MD",
  "ro-RO",
  "ru-RU",
  "si-LK",
  "sk-SK",
  "sl-SI",
  "so-SO",
  "sq-AL",
  "sq-XK",
  "sr-ME",
  "sr-RS",
  "sv-SE",
  "sw-TZ",
  "ta-IN",
  "te-IN",
  "th-TH",
  "tl-PH",
  "tr-TR",
  "uk-UA",
  "ur-PK",
  "uz-UZ",
  "vi-VN",
  "zh-CN",
  "zh-HK",
  "zh-SG",
  "zh-TW",
  "zu-ZA"
]

@infosebas
Copy link
Author

I agree with mynameisbogdan. I don't mind using French (France) translation for the UI. If I can have Movie Info Language in French (Canadian) fr-CA I'll be happy with that :)

@mynameisbogdan mynameisbogdan changed the title Add French (Canadian) language Use TMDb languages for Movie Info Language Sep 29, 2024
@bakerboy448
Copy link
Contributor

Given the revised FR - dupe of #7788 ?

@mynameisbogdan
Copy link
Collaborator

No, like I said movie info language should not depend on the inner translation working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Help Wanted Help Wanted, no immediate plans for effort on this Status: Needs Triage New Issue needing triage Type: Feature Request Issue is a feature request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mynameisbogdan @bakerboy448 @infosebas