Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: view source content in app #655

Merged
merged 13 commits into from
Sep 29, 2024
Merged

feat: view source content in app #655

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2202ce8
feat: support source content view
lawvs Sep 26, 2024
6f080db
refactor: use context menu for toggling source content view
lawvs Sep 26, 2024
96997f4
refactor: update source content view entry
lawvs Sep 27, 2024
dbc47e2
refactor: show source content in modal in social media and video
lawvs Sep 27, 2024
06fe004
refactor: add SourceContentView component for displaying external con…
lawvs Sep 27, 2024
a25ad5d
feat: add banner for unsupported websites in SourceContentView
lawvs Sep 27, 2024
0d667e3
refactor: replace iframe with SourceContentView in source content modal
lawvs Sep 27, 2024
4d2904d
chore: clean code
lawvs Sep 28, 2024
9781854
chore: update i18n
lawvs Sep 28, 2024
1430941
fix: overflow in image view
lawvs Sep 28, 2024
3087530
Merge branch 'dev' into feat/source-view-poc
Innei Sep 28, 2024
053a08c
chore: add fi icon
Innei Sep 28, 2024
be1e9be
fix: improve loading stability in SourceContentView
lawvs Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: update i18n
  • Loading branch information
@lawvs
lawvs committed Sep 28, 2024
commit 9781854bd475de240f427eeb442294e6cec50ce1
5 changes: 2 additions & 3 deletions apps/renderer/src/hooks/biz/useEntryActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,9 +361,8 @@ export const useEntryActions = ({
},
},
{
key: "openSourceContent",
// TODO update i18n
name: "Open source content",
key: "viewSourceContent",
name: t("entry_actions.view_source_content"),
// shortcut: shortcuts.entry.openInBrowser.key,
className: "i-mgc-world-2-cute-re",
hide: !populatedEntry.entries.url,
Expand Down
1 change: 1 addition & 0 deletions locales/app/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
"entry_actions.tip": "Tip",
"entry_actions.unstar": "Unstar",
"entry_actions.unstarred": "Unstarred.",
"entry_actions.view_source_content": "View source content",
"entry_column.filtered_content_tip": "You have filtered content hidden.",
"entry_column.filtered_content_tip_2": "In addition to the entries shown above, there is also filtered content.",
"entry_column.refreshing": "Refreshing new entries...",
Expand Down
1 change: 1 addition & 0 deletions locales/app/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
"entry_actions.tip": "打赏",
"entry_actions.unstar": "取消收藏",
"entry_actions.unstarred": "取消收藏",
"entry_actions.view_source_content": "查看原文",
"entry_column.filtered_content_tip": "部分内容已被过滤隐藏",
"entry_column.filtered_content_tip_2": "除了上面显示的内容外，还有一些被过滤的内容",
"entry_column.refreshing": "正在刷新",
Expand Down