Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashes/sha2{24,56}: Remove static variables from sha256 #20116

Merged
merged 2 commits into from
Jan 16, 2024
Merged

hashes/sha2{24,56}: Remove static variables from sha256 #20116

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bac3f48
hashes/sha256: Remove static variables from sha256
bergzand Nov 29, 2023
434e564
hashes/sha224: Remove static variables from sha224
bergzand Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
hashes/sha224: Remove static variables from sha224
  • Loading branch information
@bergzand
bergzand committed Jan 16, 2024
commit 434e5647d04f8e89fa46045aa5fbbd0e546b63c5
11 changes: 3 additions & 8 deletions sys/hashes/sha224.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
*/

#include <string.h>
#include <assert.h>

#include "hashes/sha224.h"
#include "hashes/sha2xx_common.h"
Expand All @@ -40,18 +41,12 @@ void sha224_init(sha224_context_t *ctx)
ctx->state[7] = 0xBEFA4FA4;
}

void *sha224(const void *data, size_t len, void *digest)
void sha224(const void *data, size_t len, void *digest)
{
sha224_context_t c;
static unsigned char m[SHA224_DIGEST_LENGTH];

if (digest == NULL) {
digest = m;
}
assert(digest);

sha224_init(&c);
sha224_update(&c, data, len);
sha224_final(&c, digest);

return digest;
}
5 changes: 2 additions & 3 deletions sys/include/hashes/sha224.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,10 @@ static inline void sha224_final(sha224_context_t *ctx, void *digest)
*
* @param[in] data pointer to the buffer to generate hash from
* @param[in] len length of the buffer
* @param[out] digest optional pointer to an array for the result, length must
* @param[out] digest Pointer to an array for the result, length must
* be SHA224_DIGEST_LENGTH
* if digest == NULL, one static buffer is used
*/
void *sha224(const void *data, size_t len, void *digest);
void sha224(const void *data, size_t len, void *digest);

#ifdef __cplusplus
}
Expand Down
Loading