Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/at86rf2xx: isolate netdev logic #18988

Merged
merged 13 commits into from
Dec 7, 2022
+309 −437
Merged

drivers/at86rf2xx: isolate netdev logic #18988

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
06cc410
drivers/at86rf2xx_netdev: cleanup is_periph logic
jia200x Nov 28, 2022
ba6c0d8
drivers/at86rf2xx: remove unused getters
jia200x Nov 28, 2022
2965419
drivers/at86rf2xx: move addr logic to netdev
jia200x Nov 28, 2022
5207a82
drivers/at86rf2xx: simplify channel-page logic
jia200x Nov 28, 2022
72c3f91
drivers/at86rf2xx: move netdev logic out of reset function
jia200x Nov 28, 2022
fc43cec
drivers/at86rf2xx: remove unused send function
jia200x Nov 28, 2022
5a46bba
drivers/at86rf2xx: move TX_STARTED logic to netdev
jia200x Nov 28, 2022
99d490a
drivers/at86rf2xx: move at86rf2xx_setup to netdev
jia200x Nov 28, 2022
4708478
drivers/at86rf2xx: move security logic to netdev
jia200x Nov 28, 2022
bc10439
drivers/at86rf2xx: move TX power logic to netdev
jia200x Nov 28, 2022
c26365c
drivers/at86rf2xx: merge configure_phy and set_txpower functions
jia200x Nov 28, 2022
42af1f0
drivers/at86rf2xx: move CSMA/CA seed init to netdev init
jia200x Nov 28, 2022
1d60301
doccheck: update AT86RF2XX macros
jia200x Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
drivers/at86rf2xx: move TX_STARTED logic to netdev
@jia200x
jia200x committed Dec 6, 2022
commit 5a46bba3766fe13a0fb3fd16f61121e3576e3611
5 changes: 0 additions & 5 deletions drivers/at86rf2xx/at86rf2xx.c
View file
Original file line number Diff line number Diff line change
@@ -265,8 +265,6 @@ size_t at86rf2xx_tx_load(at86rf2xx_t *dev, const uint8_t *data,

void at86rf2xx_tx_exec(at86rf2xx_t *dev)
{
netdev_t *netdev = &dev->netdev.netdev;

#if AT86RF2XX_HAVE_RETRIES
dev->tx_retries = -1;
#endif
@@ -276,9 +274,6 @@ void at86rf2xx_tx_exec(at86rf2xx_t *dev)
/* trigger sending of pre-loaded frame */
at86rf2xx_reg_write(dev, AT86RF2XX_REG__TRX_STATE,
AT86RF2XX_TRX_STATE__TX_START);
if (netdev->event_callback) {
netdev->event_callback(netdev, NETDEV_EVENT_TX_STARTED);
}
}

bool at86rf2xx_cca(at86rf2xx_t *dev)
6 changes: 6 additions & 0 deletions drivers/at86rf2xx/at86rf2xx_netdev.c
View file
Original file line number Diff line number Diff line change
@@ -133,6 +133,9 @@ static int _send(netdev_t *netdev, const iolist_t *iolist)
/* send data out directly if pre-loading id disabled */
if (!(dev->flags & AT86RF2XX_OPT_PRELOADING)) {
at86rf2xx_tx_exec(dev);
if (netdev->event_callback) {
netdev->event_callback(netdev, NETDEV_EVENT_TX_STARTED);
}
}
/* return the number of bytes that were actually loaded into the frame
* buffer/send out */
@@ -269,6 +272,9 @@ static int _set_state(at86rf2xx_t *dev, netopt_state_t state)
}
at86rf2xx_set_state(dev, AT86RF2XX_PHY_STATE_TX);
at86rf2xx_tx_exec(dev);
if (dev->netdev.netdev.event_callback) {
dev->netdev.netdev.event_callback(&dev->netdev.netdev, NETDEV_EVENT_TX_STARTED);
}
}
break;
case NETOPT_STATE_RESET: