Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pm: don't (un)block IDLE mode [backport 2022.04] #17975

Merged
merged 2 commits into from
Apr 21, 2022
Merged

pm: don't (un)block IDLE mode [backport 2022.04] #17975

merged 2 commits into from
Apr 21, 2022
+3 −3

Conversation

OlegHahm
Copy link
Member

Backport of #17974

Contribution description

This is already unblocked and will trigger an assertion.
The code is still broken as other modes might be unblocked too, but at least it is just as broken as it was before #17895

Testing procedure

examples/lorawan should no longer crash on most boards.
(should still crash on samd21 boards as it would since ed9f740)

Issues/PRs references

follow-up to #17895

benpicco added 2 commits April 21, 2022 14:39
@benpicco @OlegHahm
pkg/openwsn: don't block IDLE mode
a6b5f94 
(cherry picked from commit 237a447)
@benpicco @OlegHahm
examples/lorawan: don't unblock IDLE mode
43d6dc4 
This is already unblocked and will trigger an assertion.
The code is still broken as other modes might be unblocked too,
but at least it is just as broken as it was before RIOT-OS#17895

(cherry picked from commit 520aa2d)
@OlegHahm OlegHahm added Area: examples Area: Example Applications Area: network Area: Networking Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master labels Apr 21, 2022
@OlegHahm OlegHahm requested a review from kaspar030 April 21, 2022 12:40
@jia200x
Copy link
Member

jia200x commented Apr 21, 2022 •
edited
Loading

The LoRaWAN test works now:

Join procedure succeeded
Sending: This is RIOT!
Sending: This is RIOT!
TTN logs 
{
  "name": "as.up.data.forward",
  "time": "2022-04-21T12:50:17.791569181Z",
  "identifiers": [
    {
      "device_ids": {
        "device_id": "eui-70b3d57ed0046d5d-abp",
        "application_ids": {
          "application_id": "release-tests"
        }
      }
    },
    {
      "device_ids": {
        "device_id": "eui-70b3d57ed0046d5d-abp",
        "application_ids": {
          "application_id": "release-tests"
        },
        "dev_eui": "70B3D57ED0046D5D",
        "dev_addr": "260B41C7"
      }
    }
  ],
  "data": {
    "@type": "type.googleapis.com/ttn.lorawan.v3.ApplicationUp",
    "end_device_ids": {
      "device_id": "eui-70b3d57ed0046d5d-abp",
      "application_ids": {
        "application_id": "release-tests"
      },
      "dev_eui": "70B3D57ED0046D5D",
      "dev_addr": "260B41C7"
    },
    "correlation_ids": [
      "as:up:01G162RQHS4XB51D7709B2Z6KT",
      "gs:conn:01G0Y5REETHA106P7Z6833A4P9",
      "gs:up:host:01G0Y5RGJ67GERJKZF0BKR2JT7",
      "gs:uplink:01G162RQB944K4JM98KTFGDYSB",
      "ns:uplink:01G162RQBA9NWMN2RT7XRF6Y0T",
      "rpc:/ttn.lorawan.v3.GsNs/HandleUplink:01G162RQBA6NV1RYHR490J8Z4A",
      "rpc:/ttn.lorawan.v3.NsAs/HandleUplink:01G162RQHSSHRB64EAVT4MHYD4"
    ],
    "received_at": "2022-04-21T12:50:17.786095204Z",
    "uplink_message": {
      "f_port": 2,
      "f_cnt": 3,
      "frm_payload": "VGhpcyBpcyBSSU9UIQ==",
      "rx_metadata": [
        {
          "gateway_ids": {
            "gateway_id": "iot-lab-saclay-imst-lite-gw",
            "eui": "B827EBFFFEAD3932"
          },
          "time": "2022-04-21T12:50:17.571523Z",
          "timestamp": 1214182819,
          "rssi": -79,
          "channel_rssi": -79,
          "snr": 9.8,
          "location": {
            "latitude": 48.71503122196953,
            "longitude": 2.205945253372193,
            "altitude": 157,
            "source": "SOURCE_REGISTRY"
          },
          "uplink_token": "CikKJwobaW90LWxhYi1zYWNsYXktaW1zdC1saXRlLWd3Egi4J+v//q05MhCj6/vCBBoMCImmhZMGELW4qJMCILiJvper6TwqDAiJpoWTBhC4/8KQAg==",
          "channel_index": 3
        },
        {
          "gateway_ids": {
            "gateway_id": "iot-lab-saclay-gateway"
          },
          "time": "2022-04-21T12:50:17Z",
          "timestamp": 32954915,
          "rssi": -70,
          "channel_rssi": -70,
          "snr": 9.5,
          "location": {
            "latitude": 48.71503122196953,
            "longitude": 2.205945253372193,
            "altitude": 157,
            "source": "SOURCE_REGISTRY"
          },
          "uplink_token": "ChoKGAoWaW90LWxhYi1zYWNsYXktZ2F0ZXdheRCjtNsPGgwIiaaFkwYQ+ILmyQIguLGQ4no="
        }
      ],
      "settings": {
        "data_rate": {
          "lora": {
            "bandwidth": 125000,
            "spreading_factor": 7
          }
        },
        "coding_rate": "4/5",
        "frequency": "867100000",
        "timestamp": 1214182819,
        "time": "2022-04-21T12:50:17.571523Z"
      },
      "received_at": "2022-04-21T12:50:17.578184399Z",
      "confirmed": true,
      "consumed_airtime": "0.061696s",
      "locations": {
        "user": {
          "latitude": 48.71475,
          "longitude": 2.205778,
          "altitude": 165,
          "source": "SOURCE_REGISTRY"
        }
      },
      "network_ids": {
        "net_id": "000013",
        "tenant_id": "ttn",
        "cluster_id": "ttn-eu1"
      }
    }
  },
  "correlation_ids": [
    "as:up:01G162RQHS4XB51D7709B2Z6KT",
    "gs:conn:01G0Y5REETHA106P7Z6833A4P9",
    "gs:up:host:01G0Y5RGJ67GERJKZF0BKR2JT7",
    "gs:uplink:01G162RQB944K4JM98KTFGDYSB",
    "ns:uplink:01G162RQBA9NWMN2RT7XRF6Y0T",
    "rpc:/ttn.lorawan.v3.GsNs/HandleUplink:01G162RQBA6NV1RYHR490J8Z4A",
    "rpc:/ttn.lorawan.v3.NsAs/HandleUplink:01G162RQHSSHRB64EAVT4MHYD4"
  ],
  "origin": "ip-10-100-15-115.eu-west-1.compute.internal",
  "context": {
    "tenant-id": "CgN0dG4="
  },
  "visibility": {
    "rights": [
      "RIGHT_APPLICATION_TRAFFIC_READ",
      "RIGHT_APPLICATION_TRAFFIC_READ"
    ]
  },
  "unique_id": "01G162RQHZS9PSYY7D7BVJR3PM"
}

@OlegHahm OlegHahm enabled auto-merge April 21, 2022 12:54
jia200x
jia200x approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@OlegHahm OlegHahm merged commit b642445 into RIOT-OS:2022.04-branch Apr 21, 2022
@OlegHahm OlegHahm deleted the backport/2022.04/PM_NUM_MODES-count branch April 21, 2022 22:07
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jia200x jia200x

@kaspar030 kaspar030

Assignees
No one assigned
Labels
Area: examples Area: Example Applications Area: network Area: Networking Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master
Projects
None yet
Milestone
Release 2022.04
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OlegHahm @jia200x @benpicco