-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/lwip: implement netif_get_name() #16741
Conversation
f51593f
to
8b26b1e
Compare
You forgot to add testing procedures. How can I test this? |
I'm afraid there is no test case for |
You could use the function in |
Well as for testing, I can recommend the procedure of #16378:
I don't know an actual code path to trigger the new function, though: I would have expected the breakpoint on the function to be hit when entering |
I guess |
There was an ifconfig in the example, but that already printed "ET0" without triggering the new function. (Maybe the command was lwip specific? Not sure, can't test from mobile...)
|
Yepp, the new function's functionality was taken from there, but it is at the moment only duplicating the code there instead of calling the function straight-away (which I was asking both to decrease duplication and allow for testing this function :-)) |
11089b3
to
9cf149c
Compare
Well there you go
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK! Ran tests/lwip
on both master
and this PR. The test still passes and the ifconfig
output stays the same.
(only ran on |
9cf149c
to
50c5848
Compare
50c5848
to
4a00361
Compare
33922c8
to
2cf2120
Compare
2cf2120
to
4464999
Compare
🚀 🎉 |
Contribution description
This function is needed so we can use
netutils_get_ipv6()
with LWIP.The code is from
_netif_list()
.Testing procedure
Issues/PRs references
#16739