Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riotctrl_shell.tests: add missing method to MockSpawn #16132

Merged
merged 1 commit into from
Mar 3, 2021
Merged

riotctrl_shell.tests: add missing method to MockSpawn #16132

merged 1 commit into from
Mar 3, 2021

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Mar 3, 2021

Contribution description

There was an update to riotctrl which introduced the usage of another method of pexpect's spawn class: read_nonblocking to flush the read output by pexpect. The mock we currently use in the tests for riotctrl_shell does not support that method which makes the CI action test-tools fail. This fixes that.

Testing procedure

test-tools should pass again.

Issues/PRs references

Follow up on RIOT-OS/riotctrl#21

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: CI Area: Continuous Integration of RIOT components Area: tools Area: Supplementary tools labels Mar 3, 2021
@miri64 miri64 added this to the Release 2021.04 milestone Mar 3, 2021
@miri64 miri64 added CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 3, 2021
fjmolinas
fjmolinas approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, straight forward

@miri64 miri64 merged commit 02e56c2 into RIOT-OS:master Mar 3, 2021
@miri64 miri64 deleted the dist/fix/riotctrl_shell-spawnmock-method-missing branch March 3, 2021 10:51
@miri64
Copy link
Member Author

miri64 commented Mar 3, 2021

@RIOT-OS/maintainers if tools-test fails in any of the PRs you review, please ask the contributors to rebase. Now that this PR is in, this should resolve the issue.

This was referenced Mar 3, 2021
Merged
Merged
@miri64
Copy link
Member Author

miri64 commented Mar 3, 2021

Backport provided in #16142

@miri64
Copy link
Member Author

miri64 commented Mar 3, 2021

See #16140 (comment) why a backport is needed.

@kaspar030 kaspar030 added the Release notes: ignored Set on PRs that have been considered for inclusion in the current release's notes but were minor. label Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss

Assignees
No one assigned
Labels
Area: CI Area: Continuous Integration of RIOT components Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Release notes: ignored Set on PRs that have been considered for inclusion in the current release's notes but were minor. Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2021.04
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @fjmolinas @kaspar030