react-express-mongodb: lint sources

to fix some syntax issues in the existing code, the commit put in place prettier and format the code Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
Qoyyuum · May 13, 2020 · be7f09b · be7f09b
1 parent be8875c
commit be7f09b
Show file tree

Hide file tree

Showing 12 changed files with 149 additions and 140 deletions.
diff --git a/react-express-mongodb/.gitignore b/react-express-mongodb/.gitignore
@@ -2,3 +2,4 @@ frontend/node_modules/
 server/node_modules/
 .idea/
 data
+*.log
diff --git a/react-express-mongodb/backend/config/config.js b/react-express-mongodb/backend/config/config.js
@@ -1,12 +1,11 @@
-var env = process.env.NODE_ENV || 'development';
+const env = process.env.NODE_ENV || "development";
 
-if(env === 'development' || env === 'test'){
+if (env === "development" || env === "test") {
+  const config = require("./config.json");
+  const envConfig = config[env];
+  console.log(envConfig);
 
-    const config = require('./config.json')
-    let envConfig = config[env];
-    console.log(envConfig);
-
-    Object.keys(envConfig).forEach((key) => {
-        process.env[key] = envConfig[key]
-    })
+  Object.keys(envConfig).forEach((key) => {
+    process.env[key] = envConfig[key];
+  });
 }
diff --git a/react-express-mongodb/backend/config/messages.js b/react-express-mongodb/backend/config/messages.js
@@ -1,62 +1,62 @@
 module.exports = {
-    AUTHENTICATION_FAILED: {
-        code: 400,
-        message: 'Authentication failed. Please login with valid credentials.',
-        success: false,
-    },
-    SUCCESSFUL_LOGIN: {
-        code: 200,
-        message: 'Successfully logged in',
-        success: true,
-    },
-    INTERNAL_SERVER_ERROR: {
-        code: 500,
-        message: 'Something unexpected happened',
-        success: false,
-    },
-    UNAUTHORIZED: {
-        code: 401,
-        message: 'You session is expired. Please login again',
-        success: false,
-    },
-    SUCCESSFUL_DELETE: {
-        code: 200,
-        message: 'Successfully deleted',
-        success: true,
-    },
-    SUCCESSFUL_UPDATE: {
-        code: 200,
-        message: 'Updated successfully',
-        success: true,
-    },
-    SUCCESSFUL: {
-        code: 200,
-        success: true,
-        message: 'Successfully completed',
-    },
-    NOT_FOUND: {
-        code: 404,
-        success: true,
-        message: 'Requested API not found',
-    },
-    ALREADY_EXIST: {
-        code: 200,
-        success: true,
-        message: 'Already exists',
-    },
-    FORBIDDEN: {
-        code: 403,
-        message: 'You are not authorized to complete this action',
-        success: false,
-    },
-    BAD_REQUEST: {
-        code: 400,
-        message: 'Bad request. Please try again with valid parameters',
-        success: false,
-    },
-    IN_COMPLETE_REQUEST: {
-        code: 422,
-        message: 'Required parameter missing',
-        success: false,
-    },
+  AUTHENTICATION_FAILED: {
+    code: 400,
+    message: "Authentication failed. Please login with valid credentials.",
+    success: false,
+  },
+  SUCCESSFUL_LOGIN: {
+    code: 200,
+    message: "Successfully logged in",
+    success: true,
+  },
+  INTERNAL_SERVER_ERROR: {
+    code: 500,
+    message: "Something unexpected happened",
+    success: false,
+  },
+  UNAUTHORIZED: {
+    code: 401,
+    message: "You session is expired. Please login again",
+    success: false,
+  },
+  SUCCESSFUL_DELETE: {
+    code: 200,
+    message: "Successfully deleted",
+    success: true,
+  },
+  SUCCESSFUL_UPDATE: {
+    code: 200,
+    message: "Updated successfully",
+    success: true,
+  },
+  SUCCESSFUL: {
+    code: 200,
+    success: true,
+    message: "Successfully completed",
+  },
+  NOT_FOUND: {
+    code: 404,
+    success: true,
+    message: "Requested API not found",
+  },
+  ALREADY_EXIST: {
+    code: 200,
+    success: true,
+    message: "Already exists",
+  },
+  FORBIDDEN: {
+    code: 403,
+    message: "You are not authorized to complete this action",
+    success: false,
+  },
+  BAD_REQUEST: {
+    code: 400,
+    message: "Bad request. Please try again with valid parameters",
+    success: false,
+  },
+  IN_COMPLETE_REQUEST: {
+    code: 422,
+    message: "Required parameter missing",
+    success: false,
+  },
 };
diff --git a/react-express-mongodb/backend/db/index.js b/react-express-mongodb/backend/db/index.js
@@ -1,30 +1,32 @@
 /**
  * Created by Syed Afzal
  */
-const mongoose = require('mongoose');
-const {log} = require('../utils/helpers/logger');
+const mongoose = require("mongoose");
 
 exports.connect = (app) => {
-    const options = {
-        useNewUrlParser: true,
-        autoIndex: false, // Don't build indexes
-        reconnectTries: 30, // Retry up to 30 times
-        reconnectInterval: 500, // Reconnect every 500ms
-        poolSize: 10, // Maintain up to 10 socket connections
-        // If not connected, return errors immediately rather than waiting for reconnect
-        bufferMaxEntries: 0
-    }
+  const options = {
+    useNewUrlParser: true,
+    autoIndex: false, // Don't build indexes
+    reconnectTries: 30, // Retry up to 30 times
+    reconnectInterval: 500, // Reconnect every 500ms
+    poolSize: 10, // Maintain up to 10 socket connections
+    // If not connected, return errors immediately rather than waiting for reconnect
+    bufferMaxEntries: 0,
+  };
 
-    const connectWithRetry = () => {
-        mongoose.Promise = global.Promise;
-        console.log('MongoDB connection with retry')
-        mongoose.connect(process.env.MONGODB_URI, options).then(()=>{
-            console.log('MongoDB is connected');
-            app.emit('ready');
-        }).catch(err=>{
-            console.log('MongoDB connection unsuccessful, retry after 2 seconds.')
-            setTimeout(connectWithRetry, 2000)
-        })
-    }
-    connectWithRetry();
+  const connectWithRetry = () => {
+    mongoose.Promise = global.Promise;
+    console.log("MongoDB connection with retry");
+    mongoose
+      .connect(process.env.MONGODB_URI, options)
+      .then(() => {
+        console.log("MongoDB is connected");
+        app.emit("ready");
+      })
+      .catch((err) => {
+        console.log("MongoDB connection unsuccessful, retry after 2 seconds.");
+        setTimeout(connectWithRetry, 2000);
+      });
+  };
+  connectWithRetry();
 };
diff --git a/react-express-mongodb/backend/logs/.gitkeep b/react-express-mongodb/backend/logs/.gitkeep
diff --git a/react-express-mongodb/backend/logs/project.log b/react-express-mongodb/backend/logs/project.log
diff --git a/...ongodb/backend/models/todos/todo.model.js → ...ress-mongodb/backend/models/todos/todo.js b/...ongodb/backend/models/todos/todo.model.js → ...ress-mongodb/backend/models/todos/todo.js
@@ -3,7 +3,7 @@
  */
 const mongoose = require('mongoose');
 
-var Todo = mongoose.model('Todo', {
+const Todo = mongoose.model('Todo', {
     text : {
         type: String,
         trim: true,

diff --git a/react-express-mongodb/backend/package-lock.json b/react-express-mongodb/backend/package-lock.json
diff --git a/react-express-mongodb/backend/package.json b/react-express-mongodb/backend/package.json
@@ -5,6 +5,8 @@
   "main": "index.js",
   "scripts": {
     "start": "node server.js",
+    "format": "prettier --write {**/,}*.js",
+    "lint": "prettier --check {**/,}*.js",
     "dev": "nodemon server.js"
   },
   "author": "Syed Afzal",
@@ -22,6 +24,7 @@
     "validator": "^10.1.0"
   },
   "devDependencies": {
-    "nodemon": "^2.0.3"
+    "nodemon": "^2.0.3",
+    "prettier": "^2.0.5"
   }
 }
diff --git a/react-express-mongodb/backend/routes/index.js b/react-express-mongodb/backend/routes/index.js
@@ -1,38 +1,38 @@
-const express = require('express');
-const serverResponses = require('../utils/helpers/server.responses');
-const messages = require('../config/messages');
-var {Todo} = require('../models/todos/todo.model');
+const express = require("express");
+const serverResponses = require("../utils/helpers/responses");
+const messages = require("../config/messages");
+const { Todo } = require("../models/todos/todo");
 
 const routes = (app) => {
-    const router = express.Router();
+  const router = express.Router();
 
-    router.post('/todos', (req,res)=>{
-        var todo = new Todo({
-            text: req.body.text
-        });
-
-        todo.save()
-            .then((result)=>{
-                serverResponses.sendSuccess(res,messages.SUCCESSFUL, result);
-            })
-            .catch((e) => {
-                serverResponses.sendError(res,messages.BAD_REQUEST,e)
-            })
+  router.post("/todos", (req, res) => {
+    const todo = new Todo({
+      text: req.body.text,
     });
 
-    router.get('/', (req,res) => {
-        Todo.find({}, {__v:0})
-            .then((todos)=>{
-                serverResponses.sendSuccess(res,messages.SUCCESSFUL, todos);
+    todo
+      .save()
+      .then((result) => {
+        serverResponses.sendSuccess(res, messages.SUCCESSFUL, result);
+      })
+      .catch((e) => {
+        serverResponses.sendError(res, messages.BAD_REQUEST, e);
+      });
+  });
 
-            })
-            .catch((e) => {
-                serverResponses.sendError(res,messages.BAD_REQUEST,e)
-            })
-    });
+  router.get("/", (req, res) => {
+    Todo.find({}, { __v: 0 })
+      .then((todos) => {
+        serverResponses.sendSuccess(res, messages.SUCCESSFUL, todos);
+      })
+      .catch((e) => {
+        serverResponses.sendError(res, messages.BAD_REQUEST, e);
+      });
+  });
 
-    //it's a prefix before api it is useful when you have many modules and you want to
-    //differentiate b/w each module you can use this technique
-    app.use('/api', router);
+  //it's a prefix before api it is useful when you have many modules and you want to
+  //differentiate b/w each module you can use this technique
+  app.use("/api", router);
 };
-module.exports = routes;
+module.exports = routes;
diff --git a/react-express-mongodb/backend/server.js b/react-express-mongodb/backend/server.js
@@ -1,16 +1,14 @@
 /**
  * Created by Syed Afzal
  */
-require('./config/config');
-
-const express = require('express');
-const path = require('path');
-const cookieParser = require('cookie-parser');
-const bodyParser = require('body-parser');
-const cors = require('cors');
-const db = require('./db');
-
+require("./config/config");
 
+const express = require("express");
+const path = require("path");
+const cookieParser = require("cookie-parser");
+const bodyParser = require("body-parser");
+const cors = require("cors");
+const db = require("./db");
 
 const app = express();
 
@@ -21,15 +19,15 @@ app.use(cors());
 app.use(bodyParser.json());
 app.use(bodyParser.urlencoded({ extended: false }));
 app.use(cookieParser());
-app.use(express.static(path.join(__dirname,    'public')));
+app.use(express.static(path.join(__dirname, "public")));
 
 //  adding routes
-require('./routes')(app);
+require("./routes")(app);
 
-app.on('ready', () => {
-    app.listen(3000, () => {
-        console.log("Server is up on port", 3000)
-    });
-})
+app.on("ready", () => {
+  app.listen(3000, () => {
+    console.log("Server is up on port", 3000);
+  });
+});
 
 module.exports = app;
diff --git a/...backend/utils/helpers/server.responses.js → ...ongodb/backend/utils/helpers/responses.js b/...backend/utils/helpers/server.responses.js → ...ongodb/backend/utils/helpers/responses.js
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,3 +2,4 @@ frontend/node_modules/ @@
     server/node_modules/
     .idea/
     data
+    *.log