Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature ignorefile #94

Merged
merged 21 commits into from
Sep 10, 2019
Merged

Add feature ignorefile #94

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
6ef20a9
add flag --ignore-path and default value ./.onchangeignore
Sep 8, 2019
3f76408
implements merge betwen excludes and ignore
Sep 8, 2019
bb9e0d4
change version from 6.0.0 to 6.1.0 due to the insertion of the new fe…
Sep 8, 2019
3fd224e
Revert "change version from 6.0.0 to 6.1.0 due to the insertion of th…
Sep 8, 2019
28b201a
move getgetIgnoreMergedFromIgnoreFile function to upper context
Sep 8, 2019
4861f13
fix regexp for support CRLF and LF
Sep 8, 2019
94d5999
change ignorepath to disable
Sep 8, 2019
59bc805
move logic to cli interface
Sep 8, 2019
46f63f4
remove log
Sep 8, 2019
10241c5
remove unnecessary conditional for existing file
Sep 8, 2019
9f76a41
add default filepath and ignoring invalid value
Sep 8, 2019
c6fcee7
change the name function for clarity and change 'var' to 'const/let' …
Sep 8, 2019
af180c1
Fix whitespace change
blakeembrey Sep 8, 2019
b675caf
Revert "add default filepath and ignoring invalid value"
Sep 8, 2019
bf555b1
Merge branch 'feature_ignorefile' of github.com:vinyfc93/onchange int…
Sep 8, 2019
71accd9
change custom approach to node-ignore
Sep 9, 2019
aa866fb
remove test ignore and var
Sep 9, 2019
1e90668
fix wrong name var
Sep 9, 2019
1a4941f
Move process.cwd to upper context
Sep 9, 2019
2f97103
Change to use argv.cwd
Sep 9, 2019
a6d72c5
Update .gitignore
Sep 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change ignorepath to disable
  • Loading branch information
Vinícius Carvalho committed Sep 8, 2019
commit 94d599958d360d510ed309aa3416cbc7b547161a
2 changes: 1 addition & 1 deletion cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ var options = {
outpipe: argv.outpipe,
filter: argv.filter && (Array.isArray(argv.filter) ? argv.filter : argv.filter.split(/\W+/)),
awaitWriteFinish: argv['await-write-finish'],
ignorePath: argv['ignore-path'] || './.onchangeignore'
ignorePath: argv['ignore-path']
}

if (!command && !options.outpipe) {
Expand Down
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ function onchange (match, command, rawArgs, opts = {}) {
}

function getIgnoreMergedFromIgnoreFile(exclude = [], ignorePath) {
Oak-V marked this conversation as resolved.
Show resolved Hide resolved
if(existsSync(ignorePath)) {
if(ignorePath && existsSync(ignorePath)) {
const ignoreFileString = readFileSync(ignorePath).toString('utf-8')
const ignoreFileArray = ignoreFileString.replace(/^#[^\r\n]+\r?\n/gm, '').split(/\r?\n/)

Expand Down