This repository has been archived by the owner on May 11, 2021. It is now read-only.
Allow admins to see the talks before publishing #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just as admins are allowed to see the talk schedule before it has been published to the site, admins should be able to see the list of talks as well. The talk detail page is being included for symmetry. I had considered moving the check into `Event.talks_are_published` (I would have done the same for the talk schedule) but there could be times when an admin would want to know if the talks and/or schedule had actually been published versus when it's being viewed privately.
Admins can view unpublished pages in the Talks section of the site. An alert is being added to the top of the page to draw attention to the fact that the page being viewed isn't actually published on the site yet.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just as admins are allowed to see the talk schedule before it has been
published to the site, admins should be able to see the list of talks as
well. The talk detail page is being included for symmetry.
I had considered moving the check into
Event.talks_are_published(Iwould have done the same for the talk schedule) but there could be times
when an admin would want to know if the talks and/or schedule had
actually been published versus when it's being viewed privately.
To help with this distinction, an alert is being added to the top of
each unpublished page.