Skip to content

Commit

Permalink
build: make Go 1.18 the min version, update to Go 1.19
Browse files Browse the repository at this point in the history
As usual, we keep with the last two Go versions, which means the last
year of Go release (they release every 6 months or so).

This change means we can now use the type params (generics) in the
project!
  • Loading branch information
Roasbeef committed Aug 23, 2022
1 parent f8615f9 commit 65a5eeb
Show file tree
Hide file tree
Showing 13 changed files with 22 additions and 66 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ env:
# /dev.Dockerfile
# /make/builder.Dockerfile
# /.github/workflows/release.yml
GO_VERSION: 1.18.2
GO_VERSION: 1.19.0

jobs:
########################
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ env:
# /dev.Dockerfile
# /make/builder.Dockerfile
# /.github/workflows/main.yml
GO_VERSION: 1.18.2
GO_VERSION: 1.19.0

jobs:
main:
Expand Down
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ go:
# /make/builder.Dockerfile
# /.github/workflows/main.yml
# /.github/workflows/release.yml
- "1.18.2"
- "1.19.0"

env:
global:
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# /make/builder.Dockerfile
# /.github/workflows/main.yml
# /.github/workflows/release.yml
FROM golang:1.18.2-alpine as builder
FROM golang:1.19-alpine as builder

# Force Go to use the cgo based DNS resolver. This is required to ensure DNS
# queries required to connect to linked containers succeed.
Expand Down
2 changes: 1 addition & 1 deletion dev.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# /make/builder.Dockerfile
# /.github/workflows/main.yml
# /.github/workflows/release.yml
FROM golang:1.18.2-alpine as builder
FROM golang:1.19-alpine as builder

LABEL maintainer="Olaoluwa Osuntokun <laolu@lightning.engineering>"

Expand Down
2 changes: 1 addition & 1 deletion docker/btcd/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.17.3-alpine as builder
FROM golang:1.19-alpine as builder

LABEL maintainer="Olaoluwa Osuntokun <laolu@lightning.engineering>"

Expand Down
2 changes: 1 addition & 1 deletion docker/ltcd/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.17.3-alpine as builder
FROM golang:1.19-alpine as builder

LABEL maintainer="Olaoluwa Osuntokun <laolu@lightning.engineering>"

Expand Down
13 changes: 11 additions & 2 deletions docs/release-notes/release-notes-0.16.0.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Release Notes

## BOLT Specs

* Warning messages from peers are now recognized and
[logged](https://github.com/lightningnetwork/lnd/pull/6546) by lnd.

## RPC

The `RegisterConfirmationsNtfn` call of the `chainnotifier` RPC sub-server [now
Expand All @@ -18,9 +23,13 @@ transaction](https://github.com/lightningnetwork/lnd/pull/6730).

* [Add list addresses RPC](https://github.com/lightningnetwork/lnd/pull/6596).

## Build

[The project has updated to Go
1.19](https://github.com/lightningnetwork/lnd/pull/6795)! Go 1.18 is now the
minimum version needed to build the project.

## Misc
* Warning messages from peers are now recognized and
[logged](https://github.com/lightningnetwork/lnd/pull/6546) by lnd.

* [Fixed error typo](https://github.com/lightningnetwork/lnd/pull/6659).

Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,6 @@ replace github.com/gogo/protobuf => github.com/gogo/protobuf v1.3.2

// If you change this please also update .github/pull_request_template.md and
// docs/INSTALL.md.
go 1.17
go 1.18

retract v0.0.2
53 changes: 0 additions & 53 deletions go.sum

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lnrpc/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.17.3-buster
FROM golang:1.19-buster

RUN apt-get update && apt-get install -y \
git \
Expand Down
2 changes: 1 addition & 1 deletion make/builder.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# /dev.Dockerfile
# /.github/workflows/main.yml
# /.github/workflows/release.yml
FROM golang:1.18.2-buster
FROM golang:1.19-buster

MAINTAINER Olaoluwa Osuntokun <laolu@lightning.engineering>

Expand Down
2 changes: 1 addition & 1 deletion tools/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.18.2-buster
FROM golang:1.19-buster

RUN apt-get update && apt-get install -y git
ENV GOCACHE=/tmp/build/.cache
Expand Down

0 comments on commit 65a5eeb

Please sign in to comment.