Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Request Message Update to support Remote App Execution #858

Open
JoeBatt1989 opened this issue Aug 4, 2023 · 4 comments
Open

Export Request Message Update to support Remote App Execution #858

JoeBatt1989 opened this issue Aug 4, 2023 · 4 comments
Labels
enhancement New feature or request
Milestone
0.1.27

Comments

@JoeBatt1989
Copy link
Contributor

JoeBatt1989 commented Aug 4, 2023 •
edited by mocsharp
Loading

*Describe the solution you'd like
Workflow Manager must be able to attached plugins to an export request message so that MIG knows what to do with the message, plugins can be one or more types.

New ExportRequestMessage

public class ExportRequestEvent : EventBase
{
        ...
        /// <summary>
        /// A list of data output plug-in type names to be executed by the export services.
        /// Each string must be a fully-qualified type name.
        /// E.g. <code>MyCompnay.MyProject.MyNamepsace.MyPlugin, MyCompnay.MyProject.MyNamepsace</code> where
        /// <code>MyCompnay.MyProject.MyNamepsace</code> is the name of the assembly (DLL).
        /// </summary>
        public List<string> PluginAssemblies { get; private set; }
        ...
@JoeBatt1989 JoeBatt1989 added this to the 0.4.0 milestone Aug 4, 2023
@JoeBatt1989
Copy link
Contributor Author

@mocsharp @DanielNuttall-AD @neildsouth we need to define what the schema is for the new ExportRequestMessage and how WorkflowManager would know what plugins are available, do we need a lightweight API request to MIG to make it extendable? Obviosuly could be hardcoded for now but would be good to have a single source of truth for the plugins we support

@mocsharp
Copy link
Collaborator

mocsharp commented Aug 4, 2023

@DanielNuttall-AD @neildsouth @JoeBatt1989
I have updated the MR Project-MONAI/monai-deploy-messaging#210 to include a list of plug-in assembly names instead of using an enum. Please review.

@neildsouth
Copy link
Collaborator

The above looks good and makes sense, I think if the MIG had an endpoint to query the available export plugins as @JoeBatt1989 suggested, that returned a list including fully qualified name, displayable name and description, that would complete the loop and give us info we could display to a user for selection?

@mocsharp
Copy link
Collaborator

mocsharp commented Aug 7, 2023

I will create another task to provide the APIs to query for input/output plug-ins.

@neildsouth neildsouth modified the milestones: 0.4.0, 0.1.27 Aug 23, 2023
@neildsouth neildsouth added the enhancement New feature or request label Aug 23, 2023
This was referenced Aug 23, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.27
Development

No branches or pull requests
3 participants
@mocsharp @JoeBatt1989 @neildsouth