Allow the user to create a shortcut on the desktop and/or application folder #2966

sshcrack · 2024-10-22T19:11:08Z

This pull requests adds the option for the user to select in which folder they want to create their shortcut.

(See issue #639 )

I've tested on windows but couldn't test it for linux / flatpak / AppImage / macos. But it should also work there

Signed-off-by: sshcrack <34072808+sshcrack@users.noreply.github.com>

launcher/Application.cpp

launcher/ui/MainWindow.cpp

Trial97 · 2024-10-24T21:07:38Z

Also for systems like Flatpak where we can't get the desktop or applications path I think this option/action should be just one(ask the user where he wants the shortcut to be created).

Signed-off-by: sshcrack <34072808+sshcrack@users.noreply.github.com>

sshcrack · 2024-10-25T08:41:10Z

Alright, I've just pushed the suggested changes. It works on windows, but I haven't tested for linux and can't test for macOS.

launcher/ui/MainWindow.cpp

Signed-off-by: sshcrack <34072808+sshcrack@users.noreply.github.com>

launcher/ui/MainWindow.cpp

launcher/ui/MainWindow.h

Mick235711 · 2024-11-29T17:26:47Z

I don't think this currently works with macOS; AFAIK, in macOS, createShortcut() currently ignores the first parameter and just creates an app file in the user Applications folder. Therefore, with the current code, it creates an application shortcut in macOS regardless of which option you choose.
I think we should either

Still only show one button for macOS (i.e., don't add the menu) and retain current behavior or
Properly implement desktop shortcut support for macOS.

Personally, I think this should be simple enough to implement correctly; maybe just making createShortcut() 's applicationDirectory variable respect the first argument is all that's needed for this to work. Though it's debatable if we also need a PrismLauncher Instances folder for desktop shortcuts like we have for Launchpad (application) shortcuts...

If you can't test for macOS, I can offer some assistance as I have a macOS system (aarch64) on hand.

Mick235711 · 2024-11-29T17:32:32Z

launcher/ui/MainWindow.cpp

+    if (DesktopServices::isFlatpak())
+        on_actionCreateInstanceShortcutOther_triggered();
+    else
+        on_actionCreateInstanceShortcutDesktop_triggered();


Also, maybe it is more intuitive to add a settings item to determine the default shortcut creation location instead of pre-determining it like this?
(Just my 2c, feel free to ignore)

Trial97 requested for the setting to removed, and I agree that it's not needed

TheKodeToad

Looks pretty good and worked on my Windows install!

However the macos implementation should be updated to support the desktop too... also maybe make the windows implementation put it in a start menu folder named LAUNCHER_NAME Instances too :P. I don't think you can do the same on Linux and have it work for all desktop environments though

Also it crashed for me the first time on windows but I'm not sure if you introduced this bug since I could not reproduce it again

TheKodeToad · 2024-12-01T15:22:43Z

Also mockups of ideas I had (obviously out of scope for this PR, just putting these ideas out there) (sorry they are a bit rushed and messy)

I think it'd be better as a dialog, then there's room for more options

Would be super cool if it's viable (i'll probably open a dedicated issue)

I don't think it's that easy to delete things out of the application menu/start menu/launchpad, so maybe there should also be a button to delete all shortcuts for an instance or something like this which might be overkill now I think about it

We should probably at the very least clear all shortcuts for an instance when it is deleted

sshcrack · 2024-12-01T16:18:17Z

Alright thanks for the feedback! Unfortunately I'm busy right now but will try to implement the changes in the next two weeks

TheKodeToad · 2024-12-01T17:06:55Z

I was just posting the other ideas for the sake of it, no need to implement them in this pr

sshcrack · 2024-12-01T17:12:36Z

Didn't express myself correctly 😅 meant the suggestions / fixes for mac.
Also are there any specific instructions on what exactly to change, I've got no idea of the whole mac thing (like application /desktop folders). I could look it up, but it will take some time then

Mick235711 · 2024-12-01T17:15:55Z

I'm pretty sure macOS is very similar to Linux in these regards:

For application shortcut, create a .app directory in ~/Applications/${LauncherName} Launcher/ (this is already implemented)
For a desktop shortcut, create the same .app directory in ~/Desktop
For shortcuts in other places, create the same .app directory in the directory chosen by the user

So, basically, the only difference between the three is the target directory, which actually follows the same convention as Linux afaik.

TheKodeToad · 2024-12-01T17:37:23Z

That should work, yes

sshcrack · 2024-12-07T18:45:47Z

I think creating shortcuts for MacOS should work now but couldn't test

Mick235711 · 2024-12-07T19:02:43Z

Seems to working pretty well for macOS!
Just one small nitpick: The modification to launcher/ui/pages/global files seems to be only removing a newline. Is this intended?
Otherwise LGTM.

sshcrack · 2024-12-07T19:04:50Z

Seems to working pretty well for macOS! Just one small nitpick: The modification to launcher/ui/pages/global files seems to be only removing a newline. Is this intended? Otherwise LGTM.

Nope, missed that think my editor removed the newline, will undo

sshcrack · 2024-12-07T19:21:21Z

I'm adding info for the ideas here because I couldn't find a dedicated issue yet.
To add a non-Steam game, the shortcuts.vdf file must be modified. I can't find a way to refresh the steam library to reflect changes though, I've tried steam://AddNonSteamGame or steam://flushconfig but it doesn't seem to work

Signed-off-by: sshcrack <34072808+sshcrack@users.noreply.github.com>

Mick235711 · 2024-12-07T20:46:26Z

To add a non-Steam game, the shortcuts.vdf file must be modified. I can't find a way to refresh the steam library to reflect changes though, I've tried steam://AddNonSteamGame or steam://flushconfig but it doesn't seem to work

It seems that shortcuts.vdf should be modified while the Steam client is not opened? This way there should be no refresh issues...

sshcrack · 2024-12-07T20:49:01Z

I guess so, but that would get annoying for the user. What I observed is that the shortcuts file gets refreshed when adding the shortcut

TheKodeToad · 2024-12-08T09:37:06Z

Oops, I forgot.
Opened #3176 so this pr isn't cluttered with discussion

sshcrack · 2024-12-08T17:56:36Z

launcher/ui/MainWindow.ui

@@ -779,8 +738,7 @@
  </action>
  <action name="actionViewCatPackFolder">
   <property name="icon">
-    <iconset theme="viewfolder">
-     <normaloff>.</normaloff>.</iconset>


The QT-Editor removed the <normaloff> tag for every icon. Is that okay or should I try to undo?

sshcrack added 2 commits October 22, 2024 21:20

added instance shortcut feature

a737d5d

Signed-off-by: sshcrack <34072808+sshcrack@users.noreply.github.com>

removed creation of shortcuts for flatpak / appimage users

59efca7

Signed-off-by: sshcrack <34072808+sshcrack@users.noreply.github.com>

sshcrack force-pushed the add-startmenu-shortcut branch from 1727f56 to 59efca7 Compare October 22, 2024 19:20

Trial97 reviewed Oct 24, 2024

View reviewed changes

launcher/Application.cpp Outdated Show resolved Hide resolved

Trial97 reviewed Oct 24, 2024

View reviewed changes

launcher/ui/MainWindow.cpp Outdated Show resolved Hide resolved

revert changes to settings and used menu for shortcuts

b182a88

Signed-off-by: sshcrack <34072808+sshcrack@users.noreply.github.com>

Trial97 reviewed Oct 25, 2024

View reviewed changes

launcher/ui/MainWindow.cpp Outdated Show resolved Hide resolved

launcher/ui/MainWindow.cpp Show resolved Hide resolved

launcher/ui/MainWindow.cpp Outdated Show resolved Hide resolved

sshcrack added 6 commits October 25, 2024 11:45

add back folder checks / use specific extension

ef2f865

Signed-off-by: sshcrack <34072808+sshcrack@users.noreply.github.com>

removed unnecessary macro

f1048c2

Signed-off-by: sshcrack <34072808+sshcrack@users.noreply.github.com>

remove dot

b16e12c

Signed-off-by: sshcrack <34072808+sshcrack@users.noreply.github.com>

fix default action for flatpak

43ccf18

Signed-off-by: sshcrack <34072808+sshcrack@users.noreply.github.com>

fixed typo

cd3db28

Signed-off-by: sshcrack <34072808+sshcrack@users.noreply.github.com>

hide actions if not available

7c60f37

Signed-off-by: sshcrack <34072808+sshcrack@users.noreply.github.com>

Trial97 reviewed Oct 25, 2024

View reviewed changes

launcher/ui/MainWindow.cpp Show resolved Hide resolved

Trial97 reviewed Oct 25, 2024

View reviewed changes

launcher/ui/MainWindow.h Show resolved Hide resolved

Trial97 approved these changes Oct 25, 2024

View reviewed changes

Trial97 added enhancement New feature or request changelog:changed A PR that appears under "Changed" in the changelog labels Oct 25, 2024

Trial97 added this to the 10.0 milestone Oct 29, 2024

Mick235711 reviewed Nov 29, 2024

View reviewed changes

TheKodeToad requested changes Dec 1, 2024

View reviewed changes

sshcrack added 2 commits December 7, 2024 20:25

add macos support for shortcuts

8bb35f5

Signed-off-by: sshcrack <34072808+sshcrack@users.noreply.github.com>

add newline back

c4ba7fc

Signed-off-by: sshcrack <34072808+sshcrack@users.noreply.github.com>

sshcrack force-pushed the add-startmenu-shortcut branch from 145ac6c to c4ba7fc Compare December 7, 2024 19:25

sshcrack added 2 commits December 7, 2024 20:26

git is making me crazy at this point

1cd4b49

Signed-off-by: sshcrack <34072808+sshcrack@users.noreply.github.com>

now its too much newlines??

c06f835

Signed-off-by: sshcrack <34072808+sshcrack@users.noreply.github.com>

sshcrack commented Dec 8, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow the user to create a shortcut on the desktop and/or application folder #2966

Allow the user to create a shortcut on the desktop and/or application folder #2966

sshcrack commented Oct 22, 2024 •

edited

Loading

Trial97 commented Oct 24, 2024

sshcrack commented Oct 25, 2024

Mick235711 commented Nov 29, 2024 •

edited

Loading

Mick235711 Nov 29, 2024 •

edited

Loading

TheKodeToad Dec 1, 2024

TheKodeToad left a comment

TheKodeToad commented Dec 1, 2024 •

edited

Loading

sshcrack commented Dec 1, 2024 •

edited

Loading

TheKodeToad commented Dec 1, 2024

sshcrack commented Dec 1, 2024

Mick235711 commented Dec 1, 2024 •

edited

Loading

TheKodeToad commented Dec 1, 2024

sshcrack commented Dec 7, 2024

Mick235711 commented Dec 7, 2024

sshcrack commented Dec 7, 2024

sshcrack commented Dec 7, 2024

Mick235711 commented Dec 7, 2024

sshcrack commented Dec 7, 2024

TheKodeToad commented Dec 8, 2024 •

edited

Loading

sshcrack Dec 8, 2024

Allow the user to create a shortcut on the desktop and/or application folder #2966

Are you sure you want to change the base?

Allow the user to create a shortcut on the desktop and/or application folder #2966

Conversation

sshcrack commented Oct 22, 2024 • edited Loading

Trial97 commented Oct 24, 2024

sshcrack commented Oct 25, 2024

Mick235711 commented Nov 29, 2024 • edited Loading

Mick235711 Nov 29, 2024 • edited Loading

Choose a reason for hiding this comment

TheKodeToad Dec 1, 2024

Choose a reason for hiding this comment

TheKodeToad left a comment

Choose a reason for hiding this comment

TheKodeToad commented Dec 1, 2024 • edited Loading

sshcrack commented Dec 1, 2024 • edited Loading

TheKodeToad commented Dec 1, 2024

sshcrack commented Dec 1, 2024

Mick235711 commented Dec 1, 2024 • edited Loading

TheKodeToad commented Dec 1, 2024

sshcrack commented Dec 7, 2024

Mick235711 commented Dec 7, 2024

sshcrack commented Dec 7, 2024

sshcrack commented Dec 7, 2024

Mick235711 commented Dec 7, 2024

sshcrack commented Dec 7, 2024

TheKodeToad commented Dec 8, 2024 • edited Loading

sshcrack Dec 8, 2024

Choose a reason for hiding this comment

sshcrack commented Oct 22, 2024 •

edited

Loading

Mick235711 commented Nov 29, 2024 •

edited

Loading

Mick235711 Nov 29, 2024 •

edited

Loading

TheKodeToad commented Dec 1, 2024 •

edited

Loading

sshcrack commented Dec 1, 2024 •

edited

Loading

Mick235711 commented Dec 1, 2024 •

edited

Loading

TheKodeToad commented Dec 8, 2024 •

edited

Loading